solve audio timestamp bugs and video dts/pts bugs #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winlinvip
reviewed
Mar 1, 2020
|
|
||
| //callback last media data in data buffer | ||
| on_callback(callback, _last_pid, key_path, _last_dts, _last_pts); | ||
|
|
||
| pes_parse(data_p+npos, npos, &ret_data_p, ret_size, _last_dts, _last_pts); | ||
| pes_parse(data_p+npos, npos, &ret_data_p, ret_size, dts, pts); |
There was a problem hiding this comment.
No return value checked.
TRANS_BY_GPT3
winlinvip
reviewed
Mar 1, 2020
| _rtmp_queue.insert_rtmp_data((unsigned char*)data, size, (int64_t)dts, SrsFrameTypeAudio); | ||
| rtmp_write_work(); | ||
| } else { | ||
| rtmp_write_packet(SrsFrameTypeAudio, dts, data, size); |
There was a problem hiding this comment.
You should check the return value, otherwise there may be unknown behavior.
TRANS_BY_GPT3
winlinvip
reviewed
Mar 1, 2020
Codecov Report
@@ Coverage Diff @@
## 4.0release #1621 +/- ##
============================================
Coverage ? 68.6%
============================================
Files ? 96
Lines ? 40708
Branches ? 0
============================================
Hits ? 27927
Misses ? 12781
Partials ? 0
Continue to review full report at Codecov.
|
winlinvip
added a commit
that referenced
this pull request
Mar 1, 2020
winlinvip
added a commit
that referenced
this pull request
Mar 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1,solve audio timestamp bugs;
2,solve video dts increase bugs