From 4072a8c1e4c2f5167b22ea7a19a94c28d02bf161 Mon Sep 17 00:00:00 2001
From: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
Date: Tue, 18 Aug 2020 17:12:17 +0200
Subject: [PATCH] feat(ui): title on delete buttons (#5379)

---
 ui/src/app/shared/action/action.html                  |  2 +-
 ui/src/app/shared/action/step/form/step.form.html     | 11 ++++++-----
 .../app/views/settings/action/form/action.form.html   |  2 +-
 ui/src/assets/i18n/en.json                            |  1 +
 ui/src/assets/i18n/fr.json                            |  1 +
 5 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/ui/src/app/shared/action/action.html b/ui/src/app/shared/action/action.html
index 8a0ca36df6..5575573015 100644
--- a/ui/src/app/shared/action/action.html
+++ b/ui/src/app/shared/action/action.html
@@ -146,7 +146,7 @@ <h3 class="inline">{{ 'action_step_title' | translate }}<span *ngIf="steps">{{ '
                             <div class="item">
                                 <app-delete-button
                                     (event)="sendActionEvent('delete')" [loading]="editableAction.loading"
-                                    [class]="'fluid'"></app-delete-button>
+                                    [class]="'fluid'" title="job_delete"></app-delete-button>
                             </div>
                         </div>
                     </div>
diff --git a/ui/src/app/shared/action/step/form/step.form.html b/ui/src/app/shared/action/step/form/step.form.html
index 011740396e..387ccb93f6 100644
--- a/ui/src/app/shared/action/step/form/step.form.html
+++ b/ui/src/app/shared/action/step/form/step.form.html
@@ -19,15 +19,16 @@
     </div>
     <div class="field" *ngIf="expended">
         <div class="ui buttons fluid">
-            <button class="ui green button" (click)="clickAddStep()" [disabled]="!selected"><i class="plus icon"></i>{{
-                'job_add_step' |
-                translate }}</button>
+            <button class="ui green button" (click)="clickAddStep()" [disabled]="!selected">
+                <i class="plus icon"></i>{{ 'job_add_step' | translate }}
+            </button>
             <div class="or"></div>
             <button class="ui grey button" (click)="clickCancel()">{{'btn_cancel' | translate}}</button>
         </div>
     </div>
     <div class="field" *ngIf="!expended">
-        <button class="ui fluid blue button" (click)="showActions()"><i class="plus icon"></i>{{
-            'job_add_step' | translate }}</button>
+        <button class="ui fluid blue button" (click)="showActions()">
+            <i class="plus icon"></i>{{ 'job_add_step' | translate }}
+        </button>
     </div>
 </div>
\ No newline at end of file
diff --git a/ui/src/app/views/settings/action/form/action.form.html b/ui/src/app/views/settings/action/form/action.form.html
index 46c26e4c9f..92a04ee437 100644
--- a/ui/src/app/views/settings/action/form/action.form.html
+++ b/ui/src/app/views/settings/action/form/action.form.html
@@ -125,7 +125,7 @@ <h3 class="inline">{{ 'action_step_title' | translate }}</h3>
                     </button>
                 </div>
                 <div class="eight wide column" *ngIf="action.id">
-                    <app-delete-button (event)="deleteAction()" [loading]="loading" [class]="'fluid'">
+                    <app-delete-button (event)="deleteAction()" [loading]="loading" [class]="'fluid'" title="action_delete">
                     </app-delete-button>
                 </div>
                 <div class="sixteen wide column" *ngIf="!action.id">
diff --git a/ui/src/assets/i18n/en.json b/ui/src/assets/i18n/en.json
index 0ec3021b11..be9b3cefbd 100644
--- a/ui/src/assets/i18n/en.json
+++ b/ui/src/assets/i18n/en.json
@@ -38,6 +38,7 @@
   "action_step_title": "Job steps",
   "action_list_title": "Actions",
   "action_deleted": "Action deleted",
+  "action_delete": "Delete action",
   "action_name": "Action name",
   "action_saved": "Action saved",
   "action_optional": "Optional",
diff --git a/ui/src/assets/i18n/fr.json b/ui/src/assets/i18n/fr.json
index e56bc3e309..ec44d3a095 100644
--- a/ui/src/assets/i18n/fr.json
+++ b/ui/src/assets/i18n/fr.json
@@ -41,6 +41,7 @@
   "action_builtin": "Prédéfinie",
   "action_custom": "Personnalisée",
   "action_deleted": "Action supprimée",
+  "action_delete": "Supprimer l'action",
   "action_help_add_from": "L'action courante a été initialisée à partir des données du job \"{{jobName}}\" du pipeline \"{{pipelineName}}\" dans le projet \"{{projectKey}}\". Ces données ne seront pas enregistrées tant que l'action n'aura pas été sauvegardée.",
   "action_help_line_1": "Qu'est-ce qu'une action ?",
   "action_list_title": "Actions",