fix(api): add missing rows.Close() (#4598)

ovh · Sep 11, 2019 · 65387a5 · 65387a5
1 parent 032e222
commit 65387a5
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 2 deletions.
diff --git a/engine/api/audit.go b/engine/api/audit.go
@@ -49,20 +49,19 @@ func actionAuditCleaner(db *gorp.DbMap) error {
 	if err != nil {
 		return err
 	}
+	defer rows.Close() // nolint
 	var toDel []int64
 	var actionID, count int64
 	for rows.Next() {
 		err = rows.Scan(&actionID, &count)
 		if err != nil {
-			rows.Close()
 			return err
 		}
 
 		if count > maxVersion {
 			toDel = append(toDel, actionID)
 		}
 	}
-	rows.Close()
 
 	// Now delete older version to keep only 20
 	query = `DELETE FROM action_audit

diff --git a/engine/api/broadcast/broadcast.go b/engine/api/broadcast/broadcast.go
@@ -101,6 +101,7 @@ func LoadAll(db gorp.SqlExecutor, u *sdk.User) ([]sdk.Broadcast, error) {
 	if err != nil {
 		return nil, sdk.WrapError(err, "Cannot query")
 	}
+	defer rows.Close() // nolint
 
 	broadcasts := []sdk.Broadcast{}
 	for rows.Next() {

diff --git a/engine/api/workflow/execute_node_job_run_log.go b/engine/api/workflow/execute_node_job_run_log.go
@@ -70,6 +70,7 @@ func LoadLogs(db gorp.SqlExecutor, id int64) ([]sdk.Log, error) {
 	if err != nil {
 		return nil, err
 	}
+	defer rows.Close() // nolint
 	var logs []sdk.Log
 	for rows.Next() {
 		l := &sdk.Log{}

diff --git a/engine/api/workflow/execute_node_job_run_log_service.go b/engine/api/workflow/execute_node_job_run_log_service.go
@@ -128,6 +128,7 @@ func LoadServicesLogsByJob(db gorp.SqlExecutor, nodeJobRunID int64) ([]sdk.Servi
 	if err != nil {
 		return nil, err
 	}
+	defer rows.Close() // nolint
 
 	var logs []sdk.ServiceLog
 	for rows.Next() {