fix(api): add tracing span (#3082)

ovh · Jul 26, 2018 · 7917b44 · 7917b44
1 parent a40396c
commit 7917b44
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/engine/api/workflow/execute_node_run.go b/engine/api/workflow/execute_node_run.go
@@ -757,7 +757,7 @@ type vcsInfos struct {
 	server     string
 }
 
-func getVCSInfos(db gorp.SqlExecutor, store cache.Store, proj *sdk.Project, wr *sdk.WorkflowRun, gitValues map[string]string, node *sdk.WorkflowNode, nodeRun *sdk.WorkflowNodeRun, isChildNode bool, previousGitRepo string) (vcsInfos, error) {
+func getVCSInfos(ctx context.Context, db gorp.SqlExecutor, store cache.Store, proj *sdk.Project, wr *sdk.WorkflowRun, gitValues map[string]string, node *sdk.WorkflowNode, nodeRun *sdk.WorkflowNodeRun, isChildNode bool, previousGitRepo string) (vcsInfos, error) {
 	var vcsInfos vcsInfos
 	vcsInfos.repository = gitValues[tagGitRepository]
 	vcsInfos.branch = gitValues[tagGitBranch]
@@ -771,6 +771,13 @@ func getVCSInfos(db gorp.SqlExecutor, store cache.Store, proj *sdk.Project, wr *
 		return vcsInfos, nil
 	}
 
+	_, end := tracing.Span(ctx, "workflow.getVCSInfos",
+		tracing.Tag("application", node.Context.Application.Name),
+		tracing.Tag("vcs_server", node.Context.Application.VCSServer),
+		tracing.Tag("vcs_repo", node.Context.Application.RepositoryFullname),
+	)
+	defer end()
+
 	vcsServer := repositoriesmanager.GetProjectVCSServer(proj, node.Context.Application.VCSServer)
 	if vcsServer == nil {
 		return vcsInfos, nil

diff --git a/engine/api/workflow/process.go b/engine/api/workflow/process.go
@@ -542,7 +542,7 @@ func processWorkflowNodeRun(ctx context.Context, db gorp.SqlExecutor, store cach
 
 	var vcsInfos vcsInfos
 	var errVcs error
-	vcsInfos, errVcs = getVCSInfos(db, store, p, w, gitValues, n, run, !isRoot, previousGitValues[tagGitRepository])
+	vcsInfos, errVcs = getVCSInfos(ctx, db, store, p, w, gitValues, n, run, !isRoot, previousGitValues[tagGitRepository])
 	if errVcs != nil {
 		if isRoot {
 			return report, false, sdk.WrapError(errVcs, "processWorkflowNodeRun> Cannot get VCSInfos")