fix(api): check name pattern on postProjectIntegrationHandler (#6169)

ovh · May 17, 2022 · 9aa776a · 9aa776a
1 parent 8872d84
commit 9aa776a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/engine/api/project_integration.go b/engine/api/project_integration.go
@@ -75,6 +75,7 @@ func (api *API) putProjectIntegrationHandler() service.Handler {
 			return sdk.WithStack(sdk.ErrForbidden)
 		}
 
+		projectIntegration.Name = ppDB.Name
 		projectIntegration.ID = ppDB.ID
 
 		for kkBody := range projectIntegration.Config {
@@ -210,6 +211,11 @@ func (api *API) postProjectIntegrationHandler() service.Handler {
 			return sdk.WrapError(err, "Cannot read body")
 		}
 
+		regexp := sdk.NamePatternRegex
+		if !regexp.MatchString(pp.Name) {
+			return sdk.NewErrorFrom(sdk.ErrWrongRequest, "name %q do not respect pattern %s", pp.Name, sdk.NamePattern)
+		}
+
 		pp.ProjectID = p.ID
 		if pp.IntegrationModelID == 0 {
 			pp.IntegrationModelID = pp.Model.ID

diff --git a/engine/api/project_integration_test.go b/engine/api/project_integration_test.go
@@ -45,7 +45,7 @@ func TestAddUpdateAndDeleteProjectIntegration(t *testing.T) {
 	assert.Equal(t, 200, w.Code)
 
 	// UPDATE integration
-	pp.Name = "kafkaTest2"
+	pp.Name = "kafkaTest"
 	pp.ProjectID = proj.ID
 
 	vars = map[string]string{}