fix(api): check if an application is available on the root node of a …

…workflow as code (#4215) * fix(api): check if an application is available on the root node of a workflow as code * Apply suggestions from code review
ovh · Apr 24, 2019 · ae9f724 · ae9f724
1 parent c2a4596
commit ae9f724
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/engine/api/workflow/dao.go b/engine/api/workflow/dao.go
@@ -1573,6 +1573,16 @@ func Push(ctx context.Context, db *gorp.DbMap, store cache.Store, proj *sdk.Proj
 		return nil, nil, sdk.WrapError(err, "unable to import workflow %s", data.wrkflw.Name)
 	}
 
+	// If the workflow is "as-code", it should always be linked to a git repository
+	if opts != nil && opts.FromRepository != "" {
+		if wf.Root.Context.Application == nil {
+			return nil, nil, sdk.WithStack(sdk.ErrApplicationMandatoryOnWorkflowAsCode)
+		}
+		if wf.Root.Context.Application.VCSServer == "" || wf.Root.Context.Application.RepositoryFullname == "" {
+			return nil, nil, sdk.WithStack(sdk.ErrApplicationMandatoryOnWorkflowAsCode)
+		}
+	}
+
 	if wf.Root.Context.Application != nil {
 		if err := application.Update(tx, store, wf.Root.Context.Application); err != nil {
 			return nil, nil, sdk.WrapError(err, "Unable to update application vcs datas")

diff --git a/sdk/error.go b/sdk/error.go
@@ -183,6 +183,7 @@ var (
 	ErrInvalidJobRequirementWorkerModelCapabilitites = Error{ID: 166, Status: http.StatusBadRequest}
 	ErrMalformattedStep                              = Error{ID: 167, Status: http.StatusBadRequest}
 	ErrVCSUsedByApplication                          = Error{ID: 168, Status: http.StatusBadRequest}
+	ErrApplicationMandatoryOnWorkflowAsCode          = Error{ID: 169, Status: http.StatusBadRequest}
 )
 
 var errorsAmericanEnglish = map[int]string{
@@ -348,6 +349,7 @@ var errorsAmericanEnglish = map[int]string{
 	ErrInvalidJobRequirementWorkerModelCapabilitites.ID: "Invalid job requirements: the worker model does't match with the binary requirements",
 	ErrMalformattedStep.ID:                              "Malformatted step",
 	ErrVCSUsedByApplication.ID:                          "Repository manager still used by an application",
+	ErrApplicationMandatoryOnWorkflowAsCode.ID:          "An application linked to a git repository is mandatory on the workflow root",
 }
 
 var errorsFrench = map[int]string{
@@ -513,6 +515,7 @@ var errorsFrench = map[int]string{
 	ErrInvalidJobRequirementWorkerModelCapabilitites.ID: "Pré-requis de job invalide: Le modèle de worker ne dispose pas de binaires suffisants",
 	ErrMalformattedStep.ID:                              "Étape malformée",
 	ErrVCSUsedByApplication.ID:                          "Le gestionnaire de dépot est encore utilisé par une application",
+	ErrApplicationMandatoryOnWorkflowAsCode.ID:          "Une application liée à un dépôt git est obligatoire à la racine du workflow",
 }
 
 var errorsLanguages = []map[int]string{