Skip to content

Commit

Permalink
fix(worker): use no timeout client on cdn upload (#5794)
Browse files Browse the repository at this point in the history
  • Loading branch information
sguiheux authored Apr 15, 2021
1 parent 7cb4839 commit b7adeeb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions sdk/cdsclient/client_cdn.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@ func (c *client) CDNItemUpload(ctx context.Context, cdnAddr string, signature st
if err != nil {
return time.Since(t0), err
}
_, _, _, err = c.Request(ctx, http.MethodPost, fmt.Sprintf("%s/item/upload", cdnAddr), f, SetHeader("X-CDS-WORKER-SIGNATURE", signature))
if err != nil {
if _, _, _, err := c.Stream(ctx, c.HTTPNoTimeoutClient(), http.MethodPost, fmt.Sprintf("%s/item/upload", cdnAddr), f, SetHeader("X-CDS-WORKER-SIGNATURE", signature)); err != nil {
savedError = newAPIError(fmt.Errorf("unable to upload file, try %d: %v", i+1, err))
time.Sleep(1 * time.Second)
continue
}
//_, _, _, err = c.Request(ctx, http.MethodPost, fmt.Sprintf("%s/item/upload", cdnAddr), f, SetHeader("X-CDS-WORKER-SIGNATURE", signature))
savedError = nil
break
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/cdsclient/http.go
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ func (c *client) Stream(ctx context.Context, httpClient HTTPClient, method strin
var requestError error
if rs, ok := body.(io.ReadSeeker); ok {
if _, err := rs.Seek(0, 0); err != nil {
return nil, nil, 0, newError(fmt.Errorf("request failed after %d retries: %v", i, err))
return nil, nil, 0, newError(fmt.Errorf("request failed after %d retries: %v. Original error: %v", i, err, savederror))
}
req, requestError = http.NewRequest(method, url, body)
} else {
Expand Down

0 comments on commit b7adeeb

Please sign in to comment.