fix(api): application crypto migration with null vcs_strategy (#5135)

engine/api/migrate/refactor_app_crypto.go

@@ -79,26 +79,25 @@ func refactorApplicationCrypto(ctx context.Context, db *gorp.DbMap, id int64) er
 		return sdk.WrapError(err, "unable to select and lock application %d", id)
 	}
 
-	if len(btes) == 0 {
-		return nil
-	}
-
 	var vcsStrategy sdk.RepositoryStrategy
-	if err := json.Unmarshal(btes, &vcsStrategy); err != nil {
-		return sdk.WrapError(err, "unable to unmarshal application RepositoryStrategy %d", id)
-	}
+	var clearPWD []byte
+	if len(btes) != 0 {
+		if err := json.Unmarshal(btes, &vcsStrategy); err != nil {
+			return sdk.WrapError(err, "unable to unmarshal application RepositoryStrategy %d", id)
+		}
 
-	encryptedPassword, err64 := base64.StdEncoding.DecodeString(vcsStrategy.Password)
-	if err64 != nil {
-		return sdk.WrapError(err64, "unable to decode password for application %d", id)
-	}
+		encryptedPassword, err := base64.StdEncoding.DecodeString(vcsStrategy.Password)
+		if err != nil {
+			return sdk.WrapError(err, "unable to decode password for application %d", id)
+		}
 
-	clearPWD, err := secret.Decrypt([]byte(encryptedPassword))
-	if err != nil {
-		return sdk.WrapError(err, "Unable to decrypt password for application %d", id)
-	}
+		clearPWD, err = secret.Decrypt([]byte(encryptedPassword))
+		if err != nil {
+			return sdk.WrapError(err, "Unable to decrypt password for application %d", id)
+		}
 
-	vcsStrategy.Password = string(clearPWD)
+		vcsStrategy.Password = string(clearPWD)
+	}
 
 	var tmpApp = sdk.Application{
 		ID:                 id,