Skip to content

Commit

Permalink
fix(api): load to delete run when updating node run job status (#5208)
Browse files Browse the repository at this point in the history
  • Loading branch information
richardlt authored May 27, 2020
1 parent 71bb5bf commit ec74def
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion engine/api/workflow/execute_node_job_run.go
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,9 @@ func UpdateNodeJobRunStatus(ctx context.Context, db gorp.SqlExecutor, store cach
job.Status = status

_, next := observability.Span(ctx, "workflow.LoadRunByID")
wf, errLoadWf := LoadRunByID(db, nodeRun.WorkflowRunID, LoadRunOptions{})
wf, errLoadWf := LoadRunByID(db, nodeRun.WorkflowRunID, LoadRunOptions{
WithDeleted: true,
})
next()
if errLoadWf != nil {
return nil, sdk.WrapError(errLoadWf, "workflow.UpdateNodeJobRunStatus> Unable to load run id %d", nodeRun.WorkflowRunID)
Expand Down

0 comments on commit ec74def

Please sign in to comment.