Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): returns 404 error when X-Cds-Username is not found #2922

Merged
merged 2 commits into from
Jun 20, 2018
Merged

fix(api): returns 404 error when X-Cds-Username is not found #2922

merged 2 commits into from
Jun 20, 2018

Conversation

fsamin
Copy link
Member

@fsamin fsamin commented Jun 19, 2018

  1. Description
    i don't fix in the user.LoadUserWithoutAuth function to avoid impact on the authentication layer

  2. Related issues

  3. About tests

  4. Mentions

@ovh/cds

@fsamin fsamin requested review from yesnault, sguiheux and bnjjj June 19, 2018 15:27
@bnjjj bnjjj merged commit 16c6209 into master Jun 20, 2018
@fsamin fsamin deleted the fsamin/fix-2018-06-19-17-25-13 branch June 20, 2018 19:44
@snyk-bot snyk-bot mentioned this pull request Jun 29, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnjjj bnjjj bnjjj approved these changes

@sguiheux sguiheux sguiheux approved these changes

@yesnault yesnault yesnault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fsamin @yesnault @sguiheux @bnjjj