fix(api): fix stop workflow run for purge #3149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Coenen <[email protected]>
yesnault
approved these changes
Aug 6, 2018
fsamin
requested changes
Aug 6, 2018
engine/api/workflow/dao_node_run.go
Outdated
| @@ -658,7 +658,8 @@ func updateNodeRunCommits(db gorp.SqlExecutor, id int64, commits []sdk.VCSCommit | |||
| return nil | |||
| } | |||
|
|
|||
| func updateNodeRunStatusAndStage(db gorp.SqlExecutor, nodeRun *sdk.WorkflowNodeRun) error { | |||
| // UpdateNodeRunStatusAndStage update just noderun status and stage | |||
| func UpdateNodeRunStatusAndStage(db gorp.SqlExecutor, nodeRun *sdk.WorkflowNodeRun) error { | |||
There was a problem hiding this comment.
I think updateNodeRunStatusAndStage should not be public, it's a very low-level function, only called by other private functions.
Maybe the goal achieved in the purge package querying and modifying workflowNoRun is also a bit low-level and should be in the workflow package.
Signed-off-by: Benjamin Coenen <[email protected]>
fsamin
approved these changes
Aug 6, 2018
yesnault
approved these changes
Aug 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Benjamin Coenen [email protected]
@ovh/cds