feat(hatchery): add routine status #3381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yvonnick Esnault <[email protected]>
yesnault
requested review from
bnjjj,
fsamin,
richardlt and
sguiheux
as code owners
Signed-off-by: Yvonnick Esnault <[email protected]>
|
CDS Report build-engine-cli-tools#6249.0 ✘
|
Signed-off-by: Yvonnick Esnault <[email protected]>
fsamin
requested changes
Oct 1, 2018
engine/api/workflow_queue.go
Outdated
|
|
||
| tx, errBegin := api.mustDB().Begin() | ||
| if errBegin != nil { | ||
| return sdk.WrapError(errBegin, "postSpawnInfosWorkflowJobHandler> Cannot start transaction") | ||
| } | ||
| defer tx.Rollback() | ||
|
|
||
| _, next = observability.Span(ctx, "workflow.AddSpawnInfosNodeJobRun") | ||
| if err := workflow.AddSpawnInfosNodeJobRun(tx, id, s); err != nil { | ||
| return sdk.WrapError(err, "postSpawnInfosWorkflowJobHandler> Cannot save spawn info on node job run %d for %s name %s", id, getAgent(r), r.Header.Get(cdsclient.RequestedNameHeader)) | ||
| } | ||
|
|
||
| if err := tx.Commit(); err != nil { | ||
| return sdk.WrapError(err, "postSpawnInfosWorkflowJobHandler> Cannot commit tx") |
sdk/hatchery/starter.go
Outdated
| return jobs, results | ||
| } | ||
|
|
||
| func workerStarter(h Interface, jobs <-chan workerStarterRequest, results chan<- workerStarterResult) { | ||
| func (st starter) run(h Interface, jobs <-chan workerStarterRequest, results chan<- workerStarterResult) { |
There was a problem hiding this comment.
it should be a pointer to starter
There was a problem hiding this comment.
it's workerStarter, no need starter now
fsamin
requested changes
Oct 1, 2018
sdk/hatchery/starter.go
Outdated
| @@ -48,6 +48,12 @@ func PanicDump(h Interface) func(s string) (io.WriteCloser, error) { | |||
| } | |||
| } | |||
|
|
|||
| var starters map[int]starter | |||
There was a problem hiding this comment.
where is it used ? I miss a handler, a status or some metrics using those statuses
There was a problem hiding this comment.
unused now, metrics are on /metrics
Signed-off-by: Yvonnick Esnault <[email protected]>
Signed-off-by: Yvonnick Esnault <[email protected]>
|
do not merge yet, missing tag "workerNum" on "starters_*" metrics |
Signed-off-by: Yvonnick Esnault <[email protected]>
|
done |
richardlt
approved these changes
Oct 2, 2018
fsamin
reviewed
Oct 2, 2018
engine/hatchery/stats.go
Outdated
| @@ -42,9 +42,19 @@ func (c *Common) initStats(hatcheryName string) error { | |||
| label = fmt.Sprintf("cds/%s/%s/disabled_workers", c.ServiceName(), hatcheryName) | |||
| c.stats.DisabledWorkers = stats.Int64(label, "number of disabled workers", stats.UnitDimensionless) | |||
|
|
|||
| label = fmt.Sprintf("cds/%s/%s/starters/spawning", c.ServiceName(), hatcheryName) | |||
| c.stats.StartersSpawning = stats.Int64(label, "starters spawning a worker", stats.UnitDimensionless) | |||
There was a problem hiding this comment.
i'm not sure i understand the metric, is it the number of goroutines spawning a worker ?
There was a problem hiding this comment.
a starter (= instance of a goroutine) have a label. example: hatchery_starter="9"
so,
starters_spawning{hatchery="cds-hatchery-local",hatchery_name="hatcheryLocal",hatchery_starter="9"} 2
starters_waiting{hatchery="cds-hatchery-local",hatchery_name="hatcheryLocal",hatchery_starter="9"} 2
say that goroutine n°9 had spawned 2 workers and do nothing now (as waiting = spawning).
We'll discuss about that tomorrow, I'm not 100% sure that it will be really useful to understand the life of goroutine "starter"
sguiheux
approved these changes
Oct 3, 2018
Signed-off-by: Yvonnick Esnault <[email protected]>
fsamin
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yvonnick Esnault [email protected]