feat(sdk): add ctx on WorkerList() #3405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yvonnick Esnault <[email protected]>
yesnault
requested review from
bnjjj,
fsamin,
richardlt and
sguiheux
as code owners
yesnault
changed the title
bnjjj
approved these changes
Oct 6, 2018
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Yvonnick Esnault <[email protected]>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Yvonnick Esnault <[email protected]>
Signed-off-by: Yvonnick Esnault <[email protected]>
sguiheux
approved these changes
Oct 8, 2018
fsamin
requested changes
Oct 8, 2018
| @@ -19,7 +19,9 @@ import ( | |||
| // If Take is not possible (as Job already booked for example) | |||
| // it will return true (-> can work on another job), false, otherwise | |||
| func (w *currentWorker) takeWorkflowJob(ctx context.Context, job sdk.WorkflowNodeJobRun) (bool, error) { | |||
| info, err := w.client.QueueTakeJob(job, w.bookedWJobID == job.ID) | |||
| ctxt, cancel := context.WithTimeout(ctx, 5*time.Second) | |||
sdk/hatchery/starter.go
Outdated
| @@ -189,11 +194,13 @@ func spawnWorkerForJob(h Interface, j workerStarterRequest) (bool, error) { | |||
| }, | |||
| }) | |||
|
|
|||
| ctxt2, cancel2 := context.WithTimeout(ctx, 10*time.Second) | |||
There was a problem hiding this comment.
i would prefer to name the ctx and the cancel with a real name
| //This goroutine try to get the pipeline build job every 5 seconds, if it fails, it cancel the build. | ||
| ctx, cancel := context.WithCancel(ctx) | ||
| //This goroutine try to get the job every 5 seconds, if it fails, it cancel the build. | ||
| ctx, cancel2 := context.WithCancel(ctx) |
There was a problem hiding this comment.
i would prefer to name the cancel with a real name
| @@ -57,11 +59,13 @@ func (w *currentWorker) takeWorkflowJob(ctx context.Context, job sdk.WorkflowNod | |||
| return | |||
| } | |||
| j := &sdk.WorkflowNodeJobRun{} | |||
| code, err := w.client.(cdsclient.Raw).GetJSON(fmt.Sprintf("/queue/workflows/%d/infos", jobID), j) | |||
| ctxT, cancel3 := context.WithTimeout(ctx, 5*time.Second) | |||
There was a problem hiding this comment.
i would prefer to name the ctx and the cancel with a real name
sdk/hatchery/hatchery.go
Outdated
| if int64(len(startWorkerRes.request.spawnAttempts)) < hCount { | ||
| if _, errQ := h.CDSClient().QueueJobIncAttempts(startWorkerRes.request.id); errQ != nil { | ||
| ctxt2, cancel2 := context.WithTimeout(ctx, 10*time.Second) |
There was a problem hiding this comment.
i would prefer to name the ctx and the cancel with a real name
Signed-off-by: Yvonnick Esnault <[email protected]>
golangcibot
reviewed
Oct 8, 2018
sdk/cdsclient/http.go
Outdated
| req = req.WithContext(ctx) | ||
|
|
||
| if c.config.Verbose { | ||
| log.Println("Stream > context> %s", tracingutils.DumpContext(ctx)) |
There was a problem hiding this comment.
Println call has possible formatting directive %s
sdk/cdsclient/http.go
Outdated
| } | ||
| spanCtx, ok := tracingutils.ContextToSpanContext(ctx) | ||
| if c.config.Verbose { | ||
| log.Println("setup tracing = %v (%v) on request to %s", ok, spanCtx, req.URL.String()) |
There was a problem hiding this comment.
Println call has possible formatting directive %v
|
CDS Report ut-engine#6379.0 ✘
|
Signed-off-by: Yvonnick Esnault <[email protected]>
fsamin
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yvonnick Esnault [email protected]