feat(ui): ansi and html in logs is now displayed (#3166) #3582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Coenen <[email protected]>
bnjjj
requested review from
fsamin,
richardlt,
sguiheux and
yesnault
as code owners
yesnault
approved these changes
Nov 12, 2018
richardlt
requested changes
Nov 12, 2018
|
|
||
| @Pipe({ name: 'safeHtml'}) | ||
| export class SafeHtmlPipe implements PipeTransform { | ||
| constructor(private sanitized: DomSanitizer) {} | ||
| transform(value) { | ||
| return this.sanitized.bypassSecurityTrustHtml(value); | ||
| transform(value: string, sanitize: boolean) { |
There was a problem hiding this comment.
Create unit test for <script>alert("test")</script> and <div onclick="alert('test')"></div>
richardlt
reviewed
Nov 12, 2018
| transform(value) { | ||
| return this.sanitized.bypassSecurityTrustHtml(value); | ||
| transform(value: string, sanitize: boolean) { | ||
| if (!sanitize) { |
There was a problem hiding this comment.
Maybe sanitize should not be optional for safeHtml
There was a problem hiding this comment.
The main goal here is to not do the process twice. In the ansi_up lib when we active the escape html it already do that. It's just for perf. But I'll change the default behavior in order to sanitize by default
Signed-off-by: Benjamin Coenen <[email protected]>
bnjjj
force-pushed
the
feat_logs_view
branch
from
e889838 to
0015c42
Compare
richardlt
approved these changes
Nov 13, 2018
sguiheux
requested changes
Nov 14, 2018
fsamin
approved these changes
Nov 14, 2018
Co-Authored-By: bnjjj <[email protected]>
Co-Authored-By: bnjjj <[email protected]>
sguiheux
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Benjamin Coenen [email protected]
@ovh/cds