Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): artifactDownload as code #3642

Merged
merged 2 commits into from
Nov 30, 2018
Merged

fix(api): artifactDownload as code #3642

merged 2 commits into from
Nov 30, 2018

Conversation

yesnault
Copy link
Member

close #3637

fsamin
fsamin previously requested changes Nov 27, 2018
View reviewed changes
Copy link
Member

@fsamin fsamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about application: "" exported data ?

@yesnault
cr
40e94c8 
Signed-off-by: Yvonnick Esnault <[email protected]>
@yesnault yesnault dismissed fsamin’s stale review November 30, 2018 08:05

done for app too

@yesnault yesnault merged commit f311b67 into master Nov 30, 2018
@yesnault yesnault deleted the ye-fix-#3637 branch December 15, 2018 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt left review comments

@bnjjj bnjjj bnjjj approved these changes

@sguiheux sguiheux sguiheux approved these changes

@fsamin fsamin fsamin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(sdk): artifact download as code
5 participants
@yesnault @fsamin @sguiheux @richardlt @bnjjj