feat(api,ui,cdsctl): bulk apply request for workflow template #3831

richardlt · 2019-01-07T18:05:13Z

Description
Related issues
About tests
Mentions

@ovh/cds

…with generics

…or template bulk update

…table

…k modal

…m ui

…selection in bulk modal

ovh-cds · 2019-01-08T09:22:12Z

CDS Report build-ui#7930.0 ✘

Compile
- Build UI ✘
- TU All -
- TU model ✔
- TU service ✔
- TU shared ✔
- TU views ✔

…r apply in ui

…and select default instances in ctl

…projects

fsamin

i think you forgot to git add the tests for the modified and new API handlers :)

cli/display.go

cli/ask_confirm.go

cli/cdsctl/template_bulk.go

engine/api/templates.go

ui/src/app/shared/history/history.component.ts

ui/src/app/shared/workflow-template/apply-modal/workflow-template.apply-modal.component.ts

ui/src/app/shared/workflow-template/bulk-modal/workflow-template.bulk-modal.component.ts

ui/src/app/shared/workflow-template/bulk-modal/workflow-template.bulk-modal.html

ui/src/app/views/settings/workflow-template/edit/workflow-template.edit.component.ts

…uments or file

…ate-bulk

bnjjj · 2019-01-10T10:47:19Z

cli/cdsctl/template_bulk.go

+func templateInitOperationFromParams(mwtis map[string]sdk.WorkflowTemplateInstance, minstances map[string]templateBulkInstancePath,
+	params, fileParams []templateBulkParameter) map[string]sdk.WorkflowTemplateBulkOperation {
+	// for all given instances, create an operation and reuse request if instance already exists
+	moperations := map[string]sdk.WorkflowTemplateBulkOperation{}


indicate length of minstances

bnjjj · 2019-01-10T10:49:10Z

cli/cdsctl/template_bulk.go

+
+func templateAskForInstances(wt *sdk.WorkflowTemplate, mwtis map[string]sdk.WorkflowTemplateInstance, minstances map[string]templateBulkInstancePath,
+	moperations map[string]sdk.WorkflowTemplateBulkOperation) error {
+	opts := []cli.CustomMultiSelectOption{}


use make with length of mwtis

bnjjj · 2019-01-10T10:50:21Z

cli/cdsctl/template_bulk.go

-				info = cli.Green("up to date")
-			}
+		// init map of projects and project repositories to prevent multiple api calls
+		mprojects := map[string]*sdk.Project{}


indicate length of mwtis

…ate-bulk

ovh-cds · 2019-01-11T13:54:07Z

CDS Report it#7989.0 ✘

w-it
- w-it ✘

ovh-cds · 2019-01-11T17:26:14Z

CDS Report it#7990.1 ■

w-it
- w-it ■

golangcibot · 2019-01-15T17:19:36Z

engine/api/templates_test.go

+	"github.com/ovh/cds/sdk/slug"
+)
+
+func initTemplateTestCase() {


initTemplateTestCase is unused (from deadcode)

ovh-cds · 2019-01-15T17:41:39Z

CDS Report it#8039.0 ✘

w-it
- w-it ✘

…ate-bulk

golangcibot · 2019-01-16T09:25:32Z

cli/display.go

 	go func(d *Display) {
 		for {
 			time.Sleep(100 * time.Millisecond)
 			if *d == "" || ctx.Err() != nil {
 				continue
 			}

+			for i := 0; i < count-1; i++ {
+				fmt.Printf(clear)


printf-style function with dynamic first argument and no further arguments should use print-style function instead (from megacheck)

richardlt added 16 commits January 7, 2019 14:16

chores: update usage of go mod

0535fa3

feat(cdsctl): work in progress on template bulk command

b360c64

chore: create dedicated modclean action in makefile

1e74a15

feat(cdsctl): ask for parameters on workflow bulk command

cc32ca1

feat(cdsctl): replace select and question by survey

086a02e

feat(api): work in progress on template bulk endpoint

1dcea93

feat(api): implement post template bulk handler

7592184

feat(api,cdsctl): bulk apply a template on workflow

4ac0e5a

feat(ui): add instance list for workflow template, refact data table …

de8ee25

…with generics

feat(api): rename migration script

32606ab

feat(ui): allow to use a func to define data table type, init modal f…

9672f98

…or template bulk update

feat(ui): init bulk update template modal, allow line select in data …

b35d1d8

…table

fix(ui): update workflow from template show

95ea61b

feat(ui): add update button on instance list for template, wip on bul…

1270208

…k modal

fix(sql): rename sql file

578b453

feat(ui): create component for template param, implement run bulk fro…

00164e4

…m ui

richardlt requested review from bnjjj, fsamin, sguiheux and yesnault as code owners January 7, 2019 18:05

richardlt changed the title ~~feat(api,ui,cdsctl): bulk apply request for workflow template~~ WIP feat(api,ui,cdsctl): bulk apply request for workflow template Jan 7, 2019

sguiheux approved these changes Jan 8, 2019

View reviewed changes

feat(ui,api): return project on template instance, preserve instance …

461f18b

…selection in bulk modal

richardlt added 2 commits January 8, 2019 10:47

feat(cdsctl,ui): show bulk error message in ctl, reload instance afte…

337e20f

…r apply in ui

feat(ui,cdsctl): reload instances list when closing bulk modal, sort …

4c62a96

…and select default instances in ctl

richardlt changed the title ~~WIP feat(api,ui,cdsctl): bulk apply request for workflow template~~ feat(api,ui,cdsctl): bulk apply request for workflow template Jan 8, 2019

richardlt added 2 commits January 8, 2019 11:22

fix(ui): fix ui build

914ed16

fix(api): allow group's user to get template instances for all their …

90050b4

…projects

yesnault approved these changes Jan 8, 2019

View reviewed changes

fsamin requested changes Jan 8, 2019

View reviewed changes

cli/display.go Show resolved Hide resolved

bnjjj suggested changes Jan 9, 2019

View reviewed changes

richardlt added 5 commits January 9, 2019 14:32

feat(cdsctl): template bulk allow to give instances and params as arg…

a401243

…uments or file

fix(cdsctl): create operation from instances file

a685863

fix: fix vendor for code review

fc2aa19

fix: code review

cae5b55

Merge remote-tracking branch 'origin/master' into feat-workflow-templ…

8e7ddd0

…ate-bulk

bnjjj suggested changes Jan 10, 2019

View reviewed changes

richardlt added 4 commits January 10, 2019 13:59

feat(contrib): add demo workflow skeleton template

60dc2e0

fix(ui): catch template with no parameters in form

f2ce25b

Merge remote-tracking branch 'origin/master' into feat-workflow-templ…

0911215

…ate-bulk

feat(tests): add test suite for bulk

b6a6176

richardlt added 2 commits January 15, 2019 13:55

fix(api): code review

8c4ae5e

feat(api): add functional test for apply and bulk template hanlders

46e57fa

golangcibot reviewed Jan 15, 2019

View reviewed changes

bnjjj approved these changes Jan 16, 2019

View reviewed changes

Merge remote-tracking branch 'origin/master' into feat-workflow-templ…

1ce4d8d

…ate-bulk

golangcibot reviewed Jan 16, 2019

View reviewed changes

fsamin approved these changes Jan 16, 2019

View reviewed changes

richardlt added 2 commits January 16, 2019 10:38

fix(cdsctl): code review

e94f428

fix(sql): rename sql file to 152

5b24e06

richardlt merged commit 554f327 into master Jan 16, 2019

richardlt deleted the feat-workflow-template-bulk branch January 16, 2019 10:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(api,ui,cdsctl): bulk apply request for workflow template #3831

feat(api,ui,cdsctl): bulk apply request for workflow template #3831

richardlt commented Jan 7, 2019

ovh-cds commented Jan 8, 2019

fsamin left a comment

bnjjj Jan 10, 2019

bnjjj Jan 10, 2019

richardlt Jan 15, 2019

bnjjj Jan 10, 2019

ovh-cds commented Jan 11, 2019

ovh-cds commented Jan 11, 2019

golangcibot Jan 15, 2019

ovh-cds commented Jan 15, 2019

golangcibot Jan 16, 2019

feat(api,ui,cdsctl): bulk apply request for workflow template #3831

feat(api,ui,cdsctl): bulk apply request for workflow template #3831

Conversation

richardlt commented Jan 7, 2019

ovh-cds commented Jan 8, 2019

fsamin left a comment

Choose a reason for hiding this comment

bnjjj Jan 10, 2019

Choose a reason for hiding this comment

bnjjj Jan 10, 2019

Choose a reason for hiding this comment

richardlt Jan 15, 2019

Choose a reason for hiding this comment

bnjjj Jan 10, 2019

Choose a reason for hiding this comment

ovh-cds commented Jan 11, 2019

ovh-cds commented Jan 11, 2019

golangcibot Jan 15, 2019

Choose a reason for hiding this comment

ovh-cds commented Jan 15, 2019

golangcibot Jan 16, 2019

Choose a reason for hiding this comment