Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): return more info about workflow template parsing and execution errors #3850

Merged
merged 7 commits into from
Jan 15, 2019

Conversation

richardlt
Copy link
Member

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@richardlt richardlt changed the title feat(api): return more info about workflow template parsing and execution errors WIP feat(api): return more info about workflow template parsing and execution errors Jan 14, 2019
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jan 14, 2019

CDS Report build-engine-cli-tools#8014.0 ✘

  • Build minimal
    • cdsctl linux ✘
    • Engine Build linux amd64 ✔
    • tools/debpacker ✔
    • tools/os-ansible-inventory ✔
    • Worker linux amd64 / 386 ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jan 14, 2019

CDS Report ut-engine#8014.0 ✘

  • Stage 1
    • Engine Test with DB ✘

@richardlt richardlt changed the title WIP feat(api): return more info about workflow template parsing and execution errors feat(api): return more info about workflow template parsing and execution errors Jan 14, 2019
engine/api/workflowtemplate/execute.go Outdated Show resolved Hide resolved
engine/api/workflowtemplate/execute.go Outdated Show resolved Hide resolved

if len(parsingErrs) > 0 {
var errs []sdk.WorkflowTemplateError
var causes []string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add len

@richardlt richardlt merged commit 62db688 into master Jan 15, 2019
@richardlt richardlt deleted the feat-template-error-info branch January 16, 2019 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants