-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): return more info about workflow template parsing and execution errors #3850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlt
requested review from
bnjjj,
fsamin,
sguiheux and
yesnault
as code owners
January 14, 2019 09:59
yesnault
approved these changes
Jan 14, 2019
bnjjj
approved these changes
Jan 14, 2019
richardlt
changed the title
feat(api): return more info about workflow template parsing and execution errors
WIP feat(api): return more info about workflow template parsing and execution errors
Jan 14, 2019
CDS Report build-engine-cli-tools#8014.0 ✘
|
CDS Report ut-engine#8014.0 ✘
|
richardlt
changed the title
WIP feat(api): return more info about workflow template parsing and execution errors
feat(api): return more info about workflow template parsing and execution errors
Jan 14, 2019
fsamin
requested changes
Jan 15, 2019
…e args on template ui editor
fsamin
requested changes
Jan 15, 2019
bnjjj
suggested changes
Jan 15, 2019
|
||
if len(parsingErrs) > 0 { | ||
var errs []sdk.WorkflowTemplateError | ||
var causes []string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add len
fsamin
approved these changes
Jan 15, 2019
sguiheux
approved these changes
Jan 15, 2019
bnjjj
approved these changes
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ovh/cds