fix(api): check worker model requirements on job processing #4062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsamin
requested review from
bnjjj,
richardlt,
sguiheux and
yesnault
as code owners
fsamin
force-pushed
the
fix/20190320/134322
branch
from
4212262 to
84f8e7a
Compare
fsamin
force-pushed
the
fix/20190320/134322
branch
from
84f8e7a to
77e9a7b
Compare
while computing the new job `addJobsToQueue`, the function `processNodeJobRunRequirements` now checks: * the group of the worker model againt the `execGroups` computed on the node (close #4002) * the binaries requirements against the worker model binary capabilitites In case of error, the job is failed
fsamin
force-pushed
the
fix/20190320/134322
branch
from
77e9a7b to
526bc0d
Compare
yesnault
requested changes
Mar 20, 2019
yesnault
approved these changes
Mar 22, 2019
richardlt
approved these changes
Mar 24, 2019
sguiheux
approved these changes
Mar 25, 2019
bnjjj
approved these changes
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while computing the new job
addJobsToQueue, the functionprocessNodeJobRunRequirementsnow checks:execGroupscomputed on the node (close fix:permissions on worker models #4002)In case of error, the job is failed
Related issues:
#4002
About tests:
done manually
Mentions:
@ovh/cds