feat(api): add git hash short variable auto #4119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlt
requested review from
bnjjj,
fsamin,
sguiheux and
yesnault
as code owners
richardlt
force-pushed
the
feat-git-hash-short
branch
from
f8120cf to
7d0bda4
Compare
bnjjj
approved these changes
Mar 28, 2019
fsamin
approved these changes
Mar 28, 2019
yesnault
approved these changes
Mar 28, 2019
yesnault
requested changes
Mar 29, 2019
engine/hooks/poller.go
Outdated
| @@ -17,6 +17,7 @@ func fillPayload(pushEvent sdk.VCSPushEvent) map[string]string { | |||
| payload["git.author"] = pushEvent.Commit.Author.Name | |||
| payload["git.author.email"] = pushEvent.Commit.Author.Email | |||
| payload["git.branch"] = strings.TrimPrefix(strings.TrimPrefix(pushEvent.Branch.DisplayID, "refs/heads/"), "refs/tags/") | |||
| payload["git.hash.short"] = pushEvent.Commit.Hash[:7] | |||
There was a problem hiding this comment.
length have to check to avoid a potential 'runtime error: slice bounds out of range'
sguiheux
approved these changes
Mar 29, 2019
yesnault
requested changes
Mar 29, 2019
There was a problem hiding this comment.
https://ovh.github.io/cds/docs/concepts/variables/ should be updated
yesnault
approved these changes
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ovh/cds