Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): .workflow params #4176

Merged
merged 3 commits into from
Apr 11, 2019
Merged

fix(api): .workflow params #4176

merged 3 commits into from
Apr 11, 2019

Conversation

sguiheux
Copy link
Collaborator

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

golangcibot
golangcibot reviewed Apr 10, 2019
View reviewed changes
engine/api/workflow/process_node_test.go Outdated
mockVCSSservice := &sdk.Service{Name: "TestManualRunBuildParameterMultiApplication", Type: services.TypeVCS}
test.NoError(t, services.Insert(db, mockVCSSservice))
defer func() {
services.Delete(db, mockVCSSservice)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error return value of services.Delete is not checked (from errcheck)

engine/api/workflow/process_node_test.go Outdated
mockVCSSservice := &sdk.Service{Name: "TestManualRunBuildParameterMultiApplication", Type: services.TypeVCS}
test.NoError(t, services.Insert(db, mockVCSSservice))
defer func() {
services.Delete(db, mockVCSSservice)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error return value of services.Delete is not checked (from errcheck)

@bnjjj bnjjj merged commit 6ae1ff0 into master Apr 11, 2019
@fsamin fsamin added ascode bugs, features concerning as code format and removed ascode bugs, features concerning as code format labels Apr 11, 2019
@yesnault yesnault deleted the workflowParams branch April 30, 2019 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@bnjjj bnjjj bnjjj approved these changes

@richardlt richardlt richardlt approved these changes

@fsamin fsamin fsamin approved these changes

@yesnault yesnault Awaiting requested review from yesnault yesnault is a code owner

Assignees
No one assigned
Labels
ascode bugs, features concerning as code format
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sguiheux @fsamin @richardlt @bnjjj @golangcibot