Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): db errors #4188

Merged
merged 4 commits into from
Apr 15, 2019
Merged

fix(api): db errors #4188

merged 4 commits into from
Apr 15, 2019

Conversation

sguiheux
Copy link
Collaborator

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

Copy link
Member

@fsamin fsamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rewrite the commit message

@@ -363,6 +363,12 @@ func (api *API) postSpawnInfosWorkflowJobHandler() service.AsynchronousHandler {
}
defer tx.Rollback()

if _, err := workflow.LoadNodeJobRun(tx, api.Cache, id); err != nil {
if err != sdk.ErrWorkflowNodeRunJobNotFound {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be error is ?

@richardlt richardlt merged commit 75cf412 into master Apr 15, 2019
@yesnault yesnault deleted the fixPurge branch April 30, 2019 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants