feat(hatchery): add support of private registry #4264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
bnjjj
requested review from
fsamin,
richardlt,
sguiheux and
yesnault
as code owners
Signed-off-by: Benjamin Coenen <[email protected]>
yesnault
requested changes
May 9, 2019
| @@ -383,6 +383,16 @@ func (h *HatcheryKubernetes) SpawnWorker(ctx context.Context, spawnArgs hatchery | |||
| podSchema.Spec.HostAliases[0].Hostnames[0] = "worker" | |||
| } | |||
|
|
|||
| // Check here to add secret if needed | |||
| secretName := spawnArgs.Model.Name + "-credreg" | |||
There was a problem hiding this comment.
Suggested change
| secretName := spawnArgs.Model.Name + "-credreg" | |
| secretName := "cds-credreg-" + spawnArgs.Model.Name |
Signed-off-by: Benjamin Coenen <[email protected]>
yesnault
approved these changes
May 9, 2019
richardlt
approved these changes
May 9, 2019
sguiheux
requested changes
May 13, 2019
Signed-off-by: Benjamin Coenen <[email protected]>
sguiheux
approved these changes
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close feat(hatchery/k8s): support of imagePullSecrets in podSpec #4228
close feat(hatchery/swarm): support private registry #4253
close How to create Hatchery for Kubernetes #4262
@ovh/cds