feat(contrib): add badge uservice #4335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Coenen <[email protected]>
bnjjj
requested review from
fsamin,
richardlt,
sguiheux and
yesnault
as code owners
cdumay
reviewed
May 27, 2019
| project_key -> Text, | ||
| workflow_name -> Text, | ||
| branch -> Nullable<Text>, | ||
| status -> Text, |
There was a problem hiding this comment.
You can use diesel-derive-enum to store status as enum
cdumay
reviewed
May 27, 2019
| #[derive(Default, Debug, Deserialize, Serialize, Clone)] | ||
| #[serde(default)] | ||
| pub struct BadgeConfiguration { | ||
| pub url: String, |
There was a problem hiding this comment.
You should use url::Url with the feature serde to load and implicit check the given url
cdumay
reviewed
May 27, 2019
| } | ||
|
|
||
| #[derive(Default, Debug, Deserialize, Serialize, Clone)] | ||
| pub struct HTTPConfiguration { |
There was a problem hiding this comment.
Can be replaced by std::net::SocketAddr which implement Serialize & Deserialize
There was a problem hiding this comment.
http_server(state: WebState, http_bind: String, http_port: String) ======> http_server(state: WebState, addr: SocketAddr)
with format!("{}:{}", http_bind, http_port).into()
cdumay
approved these changes
May 28, 2019
Signed-off-by: Benjamin Coenen <[email protected]>
yesnault
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Benjamin Coenen [email protected]
close feat (contrib/uservices): github badges #546
@ovh/cds