feat(api): manually delete 1 build from history #3782 #4400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Coenen <[email protected]>
bnjjj
requested review from
fsamin,
richardlt,
sguiheux and
yesnault
as code owners
|
CDS Report ut-engine#10029.0 ✘
|
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
sguiheux
approved these changes
Jun 27, 2019
yesnault
approved these changes
Jun 27, 2019
richardlt
approved these changes
Jul 1, 2019
engine/api/workflow/dao_run.go
Outdated
| @@ -41,6 +41,7 @@ type LoadRunOptions struct { | |||
| WithTests bool | |||
| WithLightTests bool | |||
| WithVulnerabilities bool | |||
| WithoutDeleted bool | |||
There was a problem hiding this comment.
To prevent returns deleted runs, maybe we should have a WithDeleted flag instead of Without. So the default case will be to return only not deleted runs. No ?
engine/api/workflow/dao_run.go
Outdated
| @@ -469,6 +473,9 @@ func loadRun(db gorp.SqlExecutor, loadOpts LoadRunOptions, query string, args .. | |||
| return nil, sdk.WrapError(err, "Unable to load workflow run. query:%s args:%v", query, args) | |||
| } | |||
| wr := sdk.WorkflowRun(*runDB) | |||
| if loadOpts.WithoutDeleted && wr.ToDelete { | |||
| return nil, sdk.ErrWorkflowNotFound | |||
There was a problem hiding this comment.
Suggested change
| return nil, sdk.ErrWorkflowNotFound | |
| return nil, sdk.WithStack(sdk.ErrWorkflowNotFound) |
Signed-off-by: Benjamin Coenen <[email protected]>
fsamin
previously requested changes
Jul 3, 2019
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Benjamin Coenen [email protected]
close feat: manually delete 1 build from history #3782
@ovh/cds