feat(api,ui): add run conditions on hook" #4654
Conversation
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
bnjjj
requested review from
fsamin,
richardlt,
sguiheux and
yesnault
as code owners
Signed-off-by: Benjamin Coenen <[email protected]>
engine/api/workflow_run.go
Outdated
| @@ -845,6 +846,38 @@ func (api *API) postWorkflowRunHandler() service.Handler { | |||
| } | |||
| } | |||
|
|
|||
| // To handle conditon on hooks | |||
ui/src/app/model/variable.model.ts
Outdated
| @@ -27,3 +27,15 @@ export class VariableAudit { | |||
| versionned: Date; | |||
| author; string; | |||
| } | |||
|
|
|||
| export let GitVariables = [ | |||
Signed-off-by: Benjamin Coenen <[email protected]>
Co-Authored-By: Yvonnick Esnault <[email protected]>
engine/api/workflow_run_test.go
Outdated
| s := sdk.NewStage("stage 1") | ||
| s.Enabled = true | ||
| s.PipelineID = pip.ID | ||
| pipeline.InsertStage(api.mustDB(), s) |
There was a problem hiding this comment.
Error return value of pipeline.InsertStage is not checked (from errcheck)
engine/api/workflow_run_test.go
Outdated
| Enabled: true, | ||
| }, | ||
| } | ||
| pipeline.InsertJob(api.mustDB(), j, s.ID, &pip) |
There was a problem hiding this comment.
Error return value of pipeline.InsertJob is not checked (from errcheck)
engine/api/workflow_run_test.go
Outdated
| s = sdk.NewStage("stage 1") | ||
| s.Enabled = true | ||
| s.PipelineID = pip2.ID | ||
| pipeline.InsertStage(api.mustDB(), s) |
There was a problem hiding this comment.
Error return value of pipeline.InsertStage is not checked (from errcheck)
engine/api/workflow_run_test.go
Outdated
| Enabled: true, | ||
| }, | ||
| } | ||
| pipeline.InsertJob(api.mustDB(), j, s.ID, &pip2) |
There was a problem hiding this comment.
Error return value of pipeline.InsertJob is not checked (from errcheck)
Signed-off-by: Benjamin Coenen <[email protected]>
engine/api/workflow_run_test.go
Outdated
| s := sdk.NewStage("stage 1") | ||
| s.Enabled = true | ||
| s.PipelineID = pip.ID | ||
| pipeline.InsertStage(api.mustDB(), s) |
There was a problem hiding this comment.
Error return value of pipeline.InsertStage is not checked (from errcheck)
engine/api/workflow_run_test.go
Outdated
| Enabled: true, | ||
| }, | ||
| } | ||
| pipeline.InsertJob(api.mustDB(), j, s.ID, &pip) |
There was a problem hiding this comment.
Error return value of pipeline.InsertJob is not checked (from errcheck)
engine/api/workflow_run_test.go
Outdated
| s = sdk.NewStage("stage 1") | ||
| s.Enabled = true | ||
| s.PipelineID = pip2.ID | ||
| pipeline.InsertStage(api.mustDB(), s) |
There was a problem hiding this comment.
Error return value of pipeline.InsertStage is not checked (from errcheck)
engine/api/workflow_run_test.go
Outdated
| Enabled: true, | ||
| }, | ||
| } | ||
| pipeline.InsertJob(api.mustDB(), j, s.ID, &pip2) |
There was a problem hiding this comment.
Error return value of pipeline.InsertJob is not checked (from errcheck)
close feat(api,ui): condition on hook catched by hook service #4591
@ovh/cds