Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): workflow hook reference #4868

Merged
merged 14 commits into from
Jan 30, 2020
Merged

fix(api): workflow hook reference #4868

merged 14 commits into from
Jan 30, 2020

Conversation

fsamin
Copy link
Member

@fsamin fsamin commented Jan 7, 2020 •
edited
Loading

If you think about new testcases hooks, i can implement them

  • Repowebhook automatically created
  • Multiple hook
  • Hooks update
  • Hooks deletion
  • Workflow as-code rename
  • Workflow non as-code rename (do not re create webhooks)
  • Workflow as-code move to another repository feat: rename a repository #4874

@fsamin fsamin force-pushed the fix/workflow_hook_ref branch from 35e7bf7 to ef0fca5 Compare January 8, 2020 14:10
golangcibot
golangcibot reviewed Jan 8, 2020
View reviewed changes
engine/api/workflow/hook.go Outdated Show resolved Hide resolved
sdk/workflow_hook.go Outdated Show resolved Hide resolved
@ovh ovh deleted a comment from ovh-cds Jan 8, 2020
@ovh ovh deleted a comment from ovh-cds Jan 8, 2020
@fsamin fsamin marked this pull request as ready for review January 8, 2020 16:17
@fsamin fsamin requested review from bnjjj and yesnault as code owners January 8, 2020 16:17
@ovh ovh deleted a comment from ovh-cds Jan 9, 2020
@ovh ovh deleted a comment from ovh-cds Jan 9, 2020
@ovh ovh deleted a comment from ovh-cds Jan 9, 2020
@ovh ovh deleted a comment from ovh-cds Jan 9, 2020
@ovh ovh deleted a comment from ovh-cds Jan 9, 2020
@ovh ovh deleted a comment from ovh-cds Jan 9, 2020
@ovh ovh deleted a comment from ovh-cds Jan 9, 2020
@fsamin fsamin force-pushed the fix/workflow_hook_ref branch from c68d1b7 to f7be521 Compare January 9, 2020 14:11
bnjjj
bnjjj suggested changes Jan 9, 2020
View reviewed changes
engine/api/workflow/workflow_parser.go Show resolved Hide resolved
engine/api/workflow_run.go Outdated Show resolved Hide resolved
@fsamin fsamin requested a review from bnjjj January 9, 2020 14:23
@ovh ovh deleted a comment from ovh-cds Jan 9, 2020
@ovh ovh deleted a comment from ovh-cds Jan 10, 2020
@fsamin
Copy link
Member Author

fsamin commented Jan 17, 2020

close #4858

@fsamin fsamin force-pushed the fix/workflow_hook_ref branch from 8a16d79 to 175447a Compare January 21, 2020 10:35
@ovh ovh deleted a comment from ovh-cds Jan 21, 2020
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jan 21, 2020

CDS Report build-all-cds#12133.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Helm Tests -
    • Standalone Tests ✘

@fsamin
fix: ref
a67ab3f 
Signed-off-by: francois  samin <[email protected]>
fsamin added 13 commits January 30, 2020 10:30
@fsamin
fix: ref
bcb99c9 
Signed-off-by: francois  samin <[email protected]>
@fsamin
test: wip
54baae1 
Signed-off-by: francois  samin <[email protected]>
@fsamin
fix(api): repowebhook and manual runs do as-code
33a3563 
Signed-off-by: francois  samin <[email protected]>
@fsamin
fix: tests
ba4472c 
Signed-off-by: francois  samin <[email protected]>
@fsamin
test(api): rename workflow as-code
fb47bb6 
Signed-off-by: francois  samin <[email protected]>
@fsamin
test(api): rename workflow as-code
8943660 
Signed-off-by: francois  samin <[email protected]>
@fsamin
fix(sdk): lint
d39946a 
Signed-off-by: francois  samin <[email protected]>
@fsamin
test(api): fix missing services
34756c6 
Signed-off-by: francois  samin <[email protected]>
@fsamin
test(api): fix webhookURL
fad3252 
in hooks returned by /task/bulks

Signed-off-by: francois  samin <[email protected]>
@fsamin
fix(api): webhookinfos can be nil
3f7bc32 
Signed-off-by: francois  samin <[email protected]>
@fsamin
test(api): reset services.NewClient
b05c298 
Signed-off-by: francois  samin <[email protected]>
@fsamin
test(api): fix Test_putWorkflowHandler
04e3caa 
Signed-off-by: francois  samin <[email protected]>
@fsamin
fix: cr
8f05c26 
Signed-off-by: francois  samin <[email protected]>
@fsamin fsamin force-pushed the fix/workflow_hook_ref branch from 90b458e to 8f05c26 Compare January 30, 2020 09:31
@sguiheux sguiheux merged commit d39462a into master Jan 30, 2020
@fsamin fsamin deleted the fix/workflow_hook_ref branch January 31, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@bnjjj bnjjj bnjjj approved these changes

@richardlt richardlt richardlt approved these changes

@sguiheux sguiheux sguiheux approved these changes

@yesnault yesnault yesnault approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fsamin @ovh-cds @yesnault @sguiheux @richardlt @bnjjj @golangcibot