fix(api): default version is 1 for pipeline #5036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should avoid this: ``` github.com/ovh/cds/engine/api.(*Router).recoverWrap.func1.1(0xc002ddb790, 0xc000b10d00, 0xc00108e420, 0x30f6100, 0xc004028370) /tmp/QnVpbGQgYW5kIFBhY2thZ2UgQWxs/run/engine/api/router.go:135 +0x483 panic(0x263db40, 0x477cf40) /usr/local/go/src/runtime/panic.go:679 +0x1b2 github.com/ovh/cds/engine/api/pipeline.ParseAndImport(0x310f640, 0xc001a20d50, 0x314f580, 0xc001a21410, 0x3156de0, 0xc001060d10, 0xc001ba5440, 0x0, 0x0, 0x30f6500, ...) /tmp/QnVpbGQgYW5kIFBhY2thZ2UgQWxs/run/engine/api/pipeline/pipeline_parser.go:25 +0x37 github.com/ovh/cds/engine/api.(*API).putImportPipelineHandler.func1(0x310f640, 0xc001a20d50, 0x3103e00, 0xc0041091c0, 0xc000b10d00, 0x0, 0x0) /tmp/QnVpbGQgYW5kIFBhY2thZ2UgQWxs/run/engine/api/pipeline_import.go:148 +0x514 github.com/ovh/cds/engine/api.(*Router).Handle.func1(0x30f6100, 0xc004028370, 0xc000b10d00) ``` Signed-off-by: Yvonnick Esnault <[email protected]>
Signed-off-by: Yvonnick Esnault <[email protected]>
yesnault
requested review from
bnjjj,
fsamin,
richardlt and
sguiheux
as code owners
fsamin
approved these changes
Mar 3, 2020
yesnault
force-pushed
the
ye-fix-default-version-pipeline
branch
from
59c770a to
7361283
Compare
|
CDS Report build-all-cds#12629.0 ■
|
richardlt
approved these changes
Mar 3, 2020
sguiheux
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.