fix: do not send setStatut + add memory cache on commit status list #5059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesnault
approved these changes
Mar 13, 2020
fsamin
requested changes
Mar 16, 2020
| if !sdk.StatusIsTerminated(nodeRun.Status) { | ||
| continue | ||
| var err error | ||
| commitsMap, err = SendVCSEvent(ctx, db, store, proj, *wr, nodeRun, commitsMap) |
There was a problem hiding this comment.
I understand the commitsMap thing, but i think it could be nice to instanciate an object (VCSEventMessenger ?) that holds and hides this commitsMap + the vcsClient and then put the SendVCSEvent function as a method of this object
| if err := sendVCSEventStatus(ctx, db, store, proj, wr, &nodeRun, notif); err != nil { | ||
| log.Error(ctx, "resyncCommitStatus> Error sending status %s %s err:%v", statusFound.State, details, err) | ||
| if err := sendVCSEventStatus(ctx, db, store, proj.Key, wr, &nodeRun, notif, vcsServer.Name, client); err != nil { | ||
| return commitsStatusMap, sdk.WrapError(err, "resyncCommitStatus> Error sending status %s %s err:%v", statusFound.State, details, err) |
There was a problem hiding this comment.
no need to display the error in the wrap
richardlt
reviewed
Mar 16, 2020
|
CDS Report build-all-cds#12761.0 ✘
|
fsamin
approved these changes
Mar 18, 2020
richardlt
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ovh/cds