Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not rerender sidebar when non changes + update children instead of destroy/recreate #5061

Merged
merged 10 commits into from
Mar 23, 2020
Merged

fix: do not rerender sidebar when non changes + update children instead of destroy/recreate #5061

merged 10 commits into from
Mar 23, 2020

Conversation

sguiheux
Copy link
Collaborator

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

fsamin
fsamin reviewed Mar 16, 2020
View reviewed changes
ui/src/app/shared/workflow/node/run/node.run.param.component.ts
@@ -352,27 +346,27 @@ export class WorkflowNodeRunParamComponent implements OnInit, AfterViewInit {
request.manual.pipeline_parameter = Parameter.formatForAPI(this.parameters);

// TODO SIMPLIFY AFTER MIGRATION
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about this TODO ?

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 23, 2020

CDS Report build-all-cds#12779.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✘
    • Docs ✔

1 similar comment
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 23, 2020

CDS Report build-all-cds#12779.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✘
    • Docs ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 23, 2020

CDS Report build-all-cds#12779.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

1 similar comment
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 23, 2020

CDS Report build-all-cds#12779.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@yesnault yesnault merged commit 454d726 into master Mar 23, 2020
@sguiheux sguiheux deleted the workflowState branch April 10, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@fsamin fsamin fsamin approved these changes

@yesnault yesnault yesnault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sguiheux @ovh-cds @yesnault @fsamin @richardlt