Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hatchery): check maxWorker with MaxProv #5063

Merged
merged 2 commits into from
Mar 17, 2020
Merged

Conversation

yesnault
Copy link
Member

this will avoid to start many workers (in the same time) if maxProv >
maxWorker in the configuration

Signed-off-by: Yvonnick Esnault [email protected]

this will avoid to start many workers (in the same time) if maxProv >
maxWorker in the configuration

Signed-off-by: Yvonnick Esnault <[email protected]>
Copy link
Member

@fsamin fsamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, i would prefer the validity of the maxProvision in configuration against the maxWorker to avoid this weird kind of setup

Signed-off-by: Yvonnick Esnault <[email protected]>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 16, 2020

CDS Report build-all-cds#12756.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✘
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@yesnault yesnault merged commit 268c001 into master Mar 17, 2020
@richardlt richardlt deleted the ye-max-worker-check branch May 20, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants