fix(api): fix hooks with empty UUID #5098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: francois samin <[email protected]>
richardlt
approved these changes
Apr 2, 2020
yesnault
approved these changes
Apr 2, 2020
|
CDS Report build-all-cds#12895.0 ✘
|
sguiheux
reviewed
Apr 3, 2020
| @@ -135,3 +135,80 @@ func cleanDuplicateHooks(ctx context.Context, db *gorp.DbMap, store cache.Store, | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| func FixEmptyUUIDHooks(ctx context.Context, db *gorp.DbMap, store cache.Store) error { | |||
| q := "select distinct(workflow.id) from w_node_hook join w_node on w_node.id = w_node_hook.node_id join workflow on workflow.id = w_node.workflow_id where uuid = ''" | |||
There was a problem hiding this comment.
request must check workflow_data->node->hooks uuid that is the right data
| @@ -707,6 +707,10 @@ func (a *API) Serve(ctx context.Context) error { | |||
| return migrate.CleanDuplicateHooks(ctx, a.DBConnectionFactory.GetDBMap(), a.Cache, false) | |||
| }}) | |||
|
|
|||
| migrate.Add(ctx, sdk.Migration{Name: "FixEmptyUUIDHooks", Release: "0.44.0", Blocker: false, Automatic: false, ExecFunc: func(ctx context.Context) error { | |||
There was a problem hiding this comment.
why not delete these hooks?
sguiheux
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: francois samin [email protected]