Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hook): fix branch and hash on pullrequest event + add docs #5105

Merged
merged 4 commits into from
Apr 7, 2020
Merged

fix(hook): fix branch and hash on pullrequest event + add docs #5105

merged 4 commits into from
Apr 7, 2020

Conversation

sguiheux
Copy link
Collaborator

@sguiheux sguiheux commented Apr 6, 2020

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

yesnault
yesnault requested changes Apr 6, 2020
View reviewed changes
docs/content/docs/concepts/variables.md
- `{{.git.message}}`: Git message of the most recent commit
- `{{.git.server}}`: Name of the repository manager
- `{{.git.repository}}`:
- Push event: Name of the repository
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a variable?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a list :)

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 6, 2020

CDS Report build-all-cds#12912.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@sguiheux sguiheux requested a review from yesnault April 6, 2020 10:08
@yesnault yesnault merged commit 10bc9a3 into master Apr 7, 2020
@sguiheux sguiheux deleted the prEvent branch April 10, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsamin fsamin fsamin approved these changes

@yesnault yesnault yesnault approved these changes

@richardlt richardlt Awaiting requested review from richardlt richardlt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sguiheux @ovh-cds @yesnault @fsamin