Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): fix loading 1st job variables #5123

Merged
merged 1 commit into from
Apr 10, 2020
Merged

fix(ui): fix loading 1st job variables #5123

merged 1 commit into from
Apr 10, 2020

Conversation

sguiheux
Copy link
Collaborator

@sguiheux sguiheux commented Apr 9, 2020

  • do not get workflow run from api if it's already in state
  • after getting noderun, updating noderunjob
  • do not select job if it's already selected
  • update job parameters if needed
    @ovh/cds

@sguiheux sguiheux merged commit de8a4f3 into master Apr 10, 2020
@sguiheux sguiheux deleted the fixLoadLogFirstJob branch April 10, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsamin fsamin fsamin approved these changes

@yesnault yesnault yesnault approved these changes

@richardlt richardlt Awaiting requested review from richardlt richardlt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sguiheux @yesnault @fsamin