Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hatchery): region prerequisite #5151

Merged
merged 6 commits into from
May 4, 2020
Merged

feat(hatchery): region prerequisite #5151

merged 6 commits into from
May 4, 2020

Conversation

yesnault
Copy link
Member

No description provided.

yesnault added 3 commits April 27, 2020 18:31
@yesnault
feat: region prerequisite
f225d55 
Signed-off-by: Yvonnick Esnault <[email protected]>
@yesnault
test: it
cd5d59b 
Signed-off-by: Yvonnick Esnault <[email protected]>
@yesnault
fix: doc
17abb64 
Signed-off-by: Yvonnick Esnault <[email protected]>
@yesnault
fix: cr
eae2ada 
Signed-off-by: Yvonnick Esnault <[email protected]>
@yesnault yesnault marked this pull request as ready for review April 28, 2020 12:37
richardlt
richardlt reviewed Apr 28, 2020
View reviewed changes
docs/content/docs/concepts/requirement/requirement_region.md Outdated Show resolved Hide resolved
engine/api/workermodel/registration.go Outdated Show resolved Hide resolved
engine/api/workermodel/registration.go Outdated Show resolved Hide resolved
@yesnault
fix: cr
af00b49 
Signed-off-by: Yvonnick Esnault <[email protected]>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 28, 2020

CDS Report build-all-cds#13108.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✘
    • Test SDK Rust ✔
    • Test UI ✔

@yesnault yesnault requested a review from richardlt April 28, 2020 15:07
@yesnault yesnault changed the title feat: region prerequisite feat(hatchery): region prerequisite Apr 28, 2020
@yesnault
fix: add check on ui
599b891 
Signed-off-by: Yvonnick Esnault <[email protected]>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 28, 2020

CDS Report build-all-cds#13115.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✘
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 29, 2020

CDS Report build-all-cds#13115.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@fsamin fsamin merged commit 05f8a8e into master May 4, 2020
@richardlt richardlt deleted the ye-region branch May 20, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@sguiheux sguiheux sguiheux approved these changes

@fsamin fsamin fsamin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yesnault @ovh-cds @fsamin @sguiheux @richardlt