Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cdn): use logrus to send worker and service log #5153

Merged
merged 25 commits into from
May 11, 2020
Merged

feat(cdn): use logrus to send worker and service log #5153

merged 25 commits into from
May 11, 2020

Conversation

sguiheux
Copy link
Collaborator

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

yesnault
yesnault requested changes Apr 28, 2020
View reviewed changes
sdk/jws/jws.go Outdated Show resolved Hide resolved
sdk/hatchery/service_log.go Outdated Show resolved Hide resolved
engine/hatchery/serve.go Outdated Show resolved Hide resolved
engine/cmd_start.go Outdated Show resolved Hide resolved
engine/cdn/cdn.go Outdated Show resolved Hide resolved
fsamin
fsamin requested changes Apr 28, 2020
View reviewed changes
engine/cdn/cdn_log.go Show resolved Hide resolved
engine/cdn/cdn_log.go Show resolved Hide resolved
engine/cdn/cdn_log.go Outdated Show resolved Hide resolved
engine/cmd_config.go Show resolved Hide resolved
engine/hatchery/serve.go Show resolved Hide resolved
@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 29, 2020

CDS Report build-all-cds#13118.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 29, 2020

CDS Report build-all-cds#13120.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@sguiheux sguiheux marked this pull request as ready for review April 29, 2020 13:53
@sguiheux sguiheux requested a review from richardlt as a code owner April 29, 2020 13:53
@sguiheux sguiheux requested review from fsamin and yesnault April 29, 2020 13:54
@ovh ovh deleted a comment from ovh-cds Apr 29, 2020
@ovh ovh deleted a comment from ovh-cds Apr 29, 2020
@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 29, 2020

CDS Report build-all-cds#13124.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 29, 2020

CDS Report build-all-cds#13126.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 30, 2020

CDS Report build-all-cds#13133.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

richardlt
richardlt requested changes Apr 30, 2020
View reviewed changes
engine/api/worker/dao.go Outdated Show resolved Hide resolved
engine/api/worker/dao.go Outdated Show resolved Hide resolved
engine/api/worker/dao.go Outdated Show resolved Hide resolved
engine/api/worker/dao.go Outdated Show resolved Hide resolved
engine/api/worker/dao.go Outdated Show resolved Hide resolved
engine/cdn/cdn.go Show resolved Hide resolved
engine/cdn/cdn_log.go Show resolved Hide resolved
engine/cdn/cdn_router.go Show resolved Hide resolved
engine/cdn/types.go Show resolved Hide resolved
sdk/log.go Outdated Show resolved Hide resolved
@richardlt
Copy link
Member

What about database signature for worker ? I think we should not ignore it but also this will require a migration to sign existing worker. Can we imagine another PR we the signature check.

sguiheux and others added 2 commits April 30, 2020 10:47
@ovh-cds
Copy link
Collaborator

ovh-cds commented May 7, 2020

CDS Report build-all-cds#13193.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented May 11, 2020

CDS Report build-all-cds#13210.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@richardlt richardlt merged commit 1a6173f into master May 11, 2020
@richardlt richardlt deleted the cdn_base branch May 20, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@fsamin fsamin fsamin approved these changes

@yesnault yesnault yesnault approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sguiheux @ovh-cds @richardlt @yesnault @fsamin