fix: take snapshot of secrets when running a workflow #5223

sguiheux · 2020-06-02T08:13:19Z

Description
Related issues
About tests
Mentions

@ovh/cds

ovh-cds · 2020-06-02T08:27:57Z

CDS Report build-all-cds#13418.1 ✘

Build
- Build and Package All ✔
- Build Debpacker ✔
- Build OS-Ansible-Inventory ✔
- Build SMTPMock ✔
- Lint UI Translate ✔
- Test CLI ✔
- Test Engine ✔
- Test SDK ✔
- Test SDK Rust ✔
- Test UI ✔
Package
- Docker ✔
- Docs ✔
Integration
- Docker Compose Tests ✔
- Standalone Tests ✘
- Standalone tests 1 -
- Standalone tests 2 -
- Standalone tests 3 -

fsamin

i miss the migration

engine/api/workflow/dao.go

engine/api/workflow/dao_run_secret.go

engine/api/workflow/execute_node_job_run.go

engine/api/workflow_hook.go

engine/api/workflow/dao_run_secret.go

engine/api/workflow/execute_node_job_run.go

engine/api/workflow_run.go

engine/api/workflow/dao_run_secret.go

engine/api/workflow/gorp_model.go

sdk/workflow_run.go

sdk/application.go

engine/api/workflow_run_test.go

engine/api/workflow_run.go

ovh-cds · 2020-06-02T14:26:10Z

CDS Report build-all-cds#13434.0 ✘

Build
- Build and Package All ✔
- Build Debpacker ✔
- Build OS-Ansible-Inventory ✔
- Build SMTPMock ✔
- Lint UI Translate ✔
- Test CLI ✔
- Test Engine ✘
- Test SDK ✔
- Test SDK Rust ✔
- Test UI ✔

ovh-cds · 2020-06-02T15:10:12Z

CDS Report build-all-cds#13438.0 ✘

Build
- Build and Package All ✔
- Build Debpacker ✔
- Build OS-Ansible-Inventory ✔
- Build SMTPMock ✔
- Lint UI Translate ✔
- Test CLI ✔
- Test Engine ✘
- Test SDK ✔
- Test SDK Rust ✔
- Test UI ✔

ovh-cds · 2020-06-03T06:22:58Z

CDS Report build-all-cds#13442.0 ✘

Build
- Build and Package All ✔
- Build Debpacker ✔
- Build OS-Ansible-Inventory ✔
- Build SMTPMock ✔
- Lint UI Translate ✔
- Test CLI ✔
- Test Engine ✘
- Test SDK ✔
- Test SDK Rust ✔
- Test UI ✔

ovh-cds · 2020-06-03T07:38:53Z

CDS Report build-all-cds#13444.0 ✘

Build
- Build and Package All ✔
- Build Debpacker ✔
- Build OS-Ansible-Inventory ✔
- Build SMTPMock ✔
- Lint UI Translate ✔
- Test CLI ✔
- Test Engine ✔
- Test SDK ✔
- Test SDK Rust ✔
- Test UI ✔
Package
- Docker ✔
- Docs ✔
Integration
- Docker Compose Tests ✔
- Standalone Tests ✘
- Standalone tests 1 -
- Standalone tests 2 -
- Standalone tests 3 -

ovh-cds · 2020-06-03T15:21:19Z

CDS Report build-all-cds#13454.0 ✘

Build
- Build and Package All ✔
- Build Debpacker ✔
- Build OS-Ansible-Inventory ✔
- Build SMTPMock ✔
- Lint UI Translate ✔
- Test CLI ✔
- Test Engine ✔
- Test SDK ✔
- Test SDK Rust ✔
- Test UI ✔
Package
- Docker ✔
- Docs ✔
Integration
- Docker Compose Tests ✘
- Standalone Tests ✘
- Standalone tests 1 -
- Standalone tests 2 -
- Standalone tests 3 -

ovh-cds · 2020-06-04T08:27:32Z

CDS Report build-all-cds#13460.0 ✘

Build
- Build and Package All ✔
- Build Debpacker ✔
- Build OS-Ansible-Inventory ✔
- Build SMTPMock ✔
- Lint UI Translate ✔
- Test CLI ✔
- Test Engine ✔
- Test SDK ✔
- Test SDK Rust ✔
- Test UI ✔
Package
- Docker ✔
- Docs ✔
Integration
- Docker Compose Tests ✔
- Standalone Tests ✘
- Standalone tests 1 -
- Standalone tests 2 -
- Standalone tests 3 -

ovh-cds · 2020-06-04T10:20:55Z

CDS Report build-all-cds#13465.0 ✘

Build
- Build and Package All ✔
- Build Debpacker ✔
- Build OS-Ansible-Inventory ✔
- Build SMTPMock ✔
- Lint UI Translate ✔
- Test CLI ✔
- Test Engine ✔
- Test SDK ✔
- Test SDK Rust ✔
- Test UI ✔
Package
- Docker ✔
- Docs ✔
Integration
- Docker Compose Tests ✔
- Standalone Tests ✘
- Standalone tests 1 -
- Standalone tests 2 -
- Standalone tests 3 -

ovh-cds · 2020-06-04T11:35:54Z

CDS Report build-all-cds#13465.1 ✘

Build
- Build and Package All ✔
- Build Debpacker ✔
- Build OS-Ansible-Inventory ✔
- Build SMTPMock ✔
- Lint UI Translate ✔
- Test CLI ✔
- Test Engine ✔
- Test SDK ✔
- Test SDK Rust ✔
- Test UI ✔
Package
- Docker ✔
- Docs ✔
Integration
- Docker Compose Tests ✔
- Standalone Tests ✘
- Standalone tests 1 -
- Standalone tests 2 -
- Standalone tests 3 -

ovh-cds · 2020-06-04T12:33:15Z

CDS Report build-all-cds#13468.0 ✘

Build
- Build and Package All ✔
- Build Debpacker ✔
- Build OS-Ansible-Inventory ✔
- Build SMTPMock ✔
- Lint UI Translate ✔
- Test CLI ✔
- Test Engine ✔
- Test SDK ✔
- Test SDK Rust ✔
- Test UI ✔
Package
- Docker ✔
- Docs ✔
Integration
- Docker Compose Tests ✔
- Standalone Tests ✘
- Standalone tests 1 -
- Standalone tests 2 -
- Standalone tests 3 -

ovh-cds · 2020-06-24T16:07:18Z

CDS Report build-all-cds#13697.1 ✘

Build
- Build and Package All ✔
- Build Debpacker ✔
- Build OS-Ansible-Inventory ✔
- Build SMTPMock ✔
- Lint UI Translate ✔
- Test CLI ✔
- Test Engine ✔
- Test SDK ✔
- Test SDK Rust ✔
- Test UI ✔
Package and Analyze
- Docker ✔
- Docs ✔
- Sonar ✔
Integration
- Docker Compose Tests ✔
- Standalone Tests ✘
- Standalone tests 1 -
- Standalone tests 2 -
- Standalone tests 3 -

engine/api/application/dao.go

ovh-cds · 2020-07-01T13:24:07Z

CDS Report build-all-cds#13750.0 ✘

Build
- Build and Package All ✔
- Build Debpacker ✔
- Build OS-Ansible-Inventory ✔
- Build SMTPMock ✔
- Lint UI Translate ✔
- Test CLI ✔
- Test Engine ✘
- Test SDK ✔
- Test SDK Rust ✔
- Test UI ✔

fsamin · 2020-07-01T13:28:52Z

engine/api/api.go

@@ -665,6 +665,10 @@ func (a *API) Serve(ctx context.Context) error {
 		authentication.SessionCleaner(ctx, a.mustDB, 10*time.Second)
 	}, a.PanicDump())

+	migrate.Add(ctx, sdk.Migration{Name: "RunsSecrets", Release: "0.47.0", Blocker: false, Automatic: true, ExecFunc: func(ctx context.Context) error {


perhaps we have to make a release before

ovh-cds · 2020-07-10T06:42:14Z

CDS Report build-all-cds#13852.0 ✘

Build
- Build and Package All ✘
- Build Debpacker ✔
- Build OS-Ansible-Inventory ✔
- Build SMTPMock ✔
- Lint UI Translate ✔
- Test CLI ✔
- Test Engine ✔
- Test SDK ✔
- Test SDK Rust ✔
- Test UI ✔

ovh-cds · 2020-07-10T07:34:36Z

CDS Report build-all-cds#13854.0 ✘

Build
- Build and Package All ✔
- Build Debpacker ✔
- Build OS-Ansible-Inventory ✔
- Build SMTPMock ✔
- Lint UI Translate ✔
- Test CLI ✔
- Test Engine ✔
- Test SDK ✔
- Test SDK Rust ✔
- Test UI ✔
Package and Analyze
- Docker ✔
- Docs ✔
- Sonar ✔
Integration
- Docker Compose Tests ✔
- Standalone Tests ✘
- Standalone tests 1 -
- Standalone tests 2 -
- Standalone tests 3 -

ovh-cds · 2020-07-10T07:51:32Z

CDS Report build-all-cds#13854.1 ✘

Build
- Build and Package All ✔
- Build Debpacker ✔
- Build OS-Ansible-Inventory ✔
- Build SMTPMock ✔
- Lint UI Translate ✔
- Test CLI ✔
- Test Engine ✔
- Test SDK ✔
- Test SDK Rust ✔
- Test UI ✔
Package and Analyze
- Docker ✔
- Docs ✔
- Sonar ✔
Integration
- Docker Compose Tests ✔
- Standalone Tests ✘
- Standalone tests 1 -
- Standalone tests 2 -
- Standalone tests 3 -

ovh-cds · 2020-07-10T08:35:07Z

CDS Report build-all-cds#13855.0 ✘

Build
- Build and Package All ✔
- Build Debpacker ✔
- Build OS-Ansible-Inventory ✔
- Build SMTPMock ✔
- Lint UI Translate ✔
- Test CLI ✔
- Test Engine ✔
- Test SDK ✔
- Test SDK Rust ✔
- Test UI ✔
Package and Analyze
- Docker ✔
- Docs ✔
- Sonar ✔
Integration
- Docker Compose Tests ✔
- Standalone Tests ✘
- Standalone tests 1 -
- Standalone tests 2 -
- Standalone tests 3 -

sonarqubecloud · 2020-07-10T09:16:11Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
9 Code Smells

54.2% Coverage
0.9% Duplication

release done

sguiheux added 5 commits May 28, 2020 16:15

feat: take a snapshot of workflow run secrets

48df10b

fix: add id primary key column + save secret on non ascode workflow

7035389

fix: unit test on RetrieveSecret/LoadSecret

a1a1d2c

feat: add unit test on as code secrets

0f63a3a

fix: do not load application/env multiple time

ba13e74

sguiheux requested review from fsamin, richardlt and yesnault as code owners June 2, 2020 08:13

fsamin requested changes Jun 2, 2020

View reviewed changes

richardlt requested changes Jun 2, 2020

View reviewed changes

sguiheux added 2 commits June 2, 2020 15:13

fix: code review

2cf860e

fix: code review

a9d56c7

fix: sql

70538b9

sguiheux added 2 commits June 3, 2020 07:57

fix: log

83e0f98

Merge branch 'master' into snapRunSecrets

0572ebc

fix: unit test

6aa2b86

feat: add migration

87388fa

feat: add type of secret. Need for worker install key

63cf135

fix: name file

253ee5b

add missing files

086f1cd

sguiheux added 2 commits June 26, 2020 18:05

fix: do not migrate run twice

f2b270a

test: reduce workers

330e9ec

sguiheux requested review from yesnault, fsamin and richardlt June 29, 2020 06:39

merge with master

c4e219c

yesnault approved these changes Jun 29, 2020

View reviewed changes

richardlt approved these changes Jul 1, 2020

View reviewed changes

fsamin reviewed Jul 1, 2020

View reviewed changes

engine/api/application/dao.go Outdated Show resolved Hide resolved

fix: code review

7a8a81c

sguiheux requested a review from fsamin July 1, 2020 13:06

chore: merge with master

455d7fd

fsamin previously requested changes Jul 1, 2020

View reviewed changes

sguiheux added 2 commits July 1, 2020 15:31

fix: project loader

d313cc9

chore: merge with master

3be7e24

sguiheux added 2 commits July 10, 2020 08:44

fix: rename sql file

aafb7d7

fix: update migration release

9b46c07

fix: add skip locked and let worker retry

d92ac8b

sguiheux added 2 commits July 10, 2020 10:44

fix: change error code to retry

c3f9620

change migrate version

f361ccc

sguiheux merged commit 7a212af into master Jul 10, 2020

richardlt deleted the snapRunSecrets branch July 13, 2020 08:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: take snapshot of secrets when running a workflow #5223

fix: take snapshot of secrets when running a workflow #5223

sguiheux commented Jun 2, 2020

ovh-cds commented Jun 2, 2020

fsamin left a comment

ovh-cds commented Jun 2, 2020

ovh-cds commented Jun 2, 2020

ovh-cds commented Jun 3, 2020

ovh-cds commented Jun 3, 2020

ovh-cds commented Jun 3, 2020

ovh-cds commented Jun 4, 2020

ovh-cds commented Jun 4, 2020

ovh-cds commented Jun 4, 2020

ovh-cds commented Jun 4, 2020

ovh-cds commented Jun 24, 2020

ovh-cds commented Jul 1, 2020

fsamin Jul 1, 2020

ovh-cds commented Jul 10, 2020

ovh-cds commented Jul 10, 2020

ovh-cds commented Jul 10, 2020

ovh-cds commented Jul 10, 2020

sonarqubecloud bot commented Jul 10, 2020 •

edited

Loading

fix: take snapshot of secrets when running a workflow #5223

fix: take snapshot of secrets when running a workflow #5223

Conversation

sguiheux commented Jun 2, 2020

ovh-cds commented Jun 2, 2020

fsamin left a comment

Choose a reason for hiding this comment

ovh-cds commented Jun 2, 2020

ovh-cds commented Jun 2, 2020

ovh-cds commented Jun 3, 2020

ovh-cds commented Jun 3, 2020

ovh-cds commented Jun 3, 2020

ovh-cds commented Jun 4, 2020

ovh-cds commented Jun 4, 2020

ovh-cds commented Jun 4, 2020

ovh-cds commented Jun 4, 2020

ovh-cds commented Jun 24, 2020

ovh-cds commented Jul 1, 2020

fsamin Jul 1, 2020

Choose a reason for hiding this comment

ovh-cds commented Jul 10, 2020

ovh-cds commented Jul 10, 2020

ovh-cds commented Jul 10, 2020

ovh-cds commented Jul 10, 2020

sonarqubecloud bot commented Jul 10, 2020 • edited Loading

sonarqubecloud bot commented Jul 10, 2020 •

edited

Loading