Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api,ui): edit application as code in CDS ui #5246

Merged
merged 12 commits into from
Jun 12, 2020
Merged

feat(api,ui): edit application as code in CDS ui #5246

merged 12 commits into from
Jun 12, 2020

Conversation

sguiheux
Copy link
Collaborator

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

richardlt
richardlt requested changes Jun 11, 2020
View reviewed changes
engine/api/application.go Outdated Show resolved Hide resolved
engine/api/application.go Show resolved Hide resolved
@sguiheux sguiheux requested a review from richardlt June 11, 2020 08:56
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug D 1 Bug
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 3 Code Smells

38.5% 38.5% Coverage
3.7% 3.7% Duplication

@ovh ovh deleted a comment from ovh-cds Jun 11, 2020
@ovh ovh deleted a comment from ovh-cds Jun 11, 2020
@yesnault yesnault merged commit 69fff58 into master Jun 12, 2020
@sguiheux sguiheux deleted the editApplicationAsCodeUI branch June 17, 2020 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@fsamin fsamin fsamin approved these changes

@yesnault yesnault yesnault approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sguiheux @yesnault @fsamin @richardlt