Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api,repositories): clean not pushed branch when checkout #5251

Merged
merged 2 commits into from
Jun 15, 2020
Merged

fix(api,repositories): clean not pushed branch when checkout #5251

merged 2 commits into from
Jun 15, 2020

Conversation

richardlt
Copy link
Member

  1. Description
    Fix repo issue and show request id in panic recovery log.

  2. Related issues

  3. About tests

  4. Mentions

@ovh/cds

@richardlt richardlt force-pushed the fix-repo-clean-checkout-not-pushed-branch branch from e4cc7df to c8fd18b Compare June 11, 2020 16:47
@ovh ovh deleted a comment from ovh-cds Jun 11, 2020
@ovh ovh deleted a comment from ovh-cds Jun 11, 2020
fsamin
fsamin requested changes Jun 12, 2020
View reviewed changes
engine/api/router.go Outdated Show resolved Hide resolved
engine/repositories/processor_checkout.go Outdated Show resolved Hide resolved
@richardlt @fsamin
fix: suggestions from code review
678122c 
Co-authored-by: François Samin <[email protected]>
@ovh ovh deleted a comment from ovh-cds Jun 12, 2020
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 29 Code Smells

40.4% 40.4% Coverage
1.2% 1.2% Duplication

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 12, 2020

CDS Report build-all-cds#13595.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package and Analyze
    • Docker ✔
    • Docs ✔
    • Sonar ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘
    • Standalone tests 1 -
    • Standalone tests 2 -
    • Standalone tests 3 -

@fsamin fsamin merged commit 78d9ac2 into master Jun 15, 2020
@richardlt richardlt deleted the fix-repo-clean-checkout-not-pushed-branch branch July 13, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sguiheux sguiheux sguiheux approved these changes

@fsamin fsamin fsamin approved these changes

@yesnault yesnault yesnault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@richardlt @ovh-cds @yesnault @fsamin @sguiheux