Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): add ascode environment edition in UI #5269

Merged
merged 16 commits into from
Jun 29, 2020
Merged

feat(ui): add ascode environment edition in UI #5269

merged 16 commits into from
Jun 29, 2020

Conversation

sguiheux
Copy link
Collaborator

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@ovh ovh deleted a comment from ovh-cds Jun 24, 2020
@ovh ovh deleted a comment from ovh-cds Jun 24, 2020
@ovh ovh deleted a comment from ovh-cds Jun 24, 2020
@ovh ovh deleted a comment from ovh-cds Jun 24, 2020
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 24, 2020

CDS Report build-all-cds#13696.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package and Analyze
    • Docker ✔
    • Docs ✔
    • Sonar ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘
    • Standalone tests 1 -
    • Standalone tests 2 -
    • Standalone tests 3 -

fsamin
fsamin requested changes Jun 29, 2020
View reviewed changes
engine/api/environment.go Show resolved Hide resolved
@sguiheux sguiheux requested a review from fsamin June 29, 2020 07:53
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 4 Code Smells

37.3% 37.3% Coverage
6.9% 6.9% Duplication

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 29, 2020

CDS Report build-all-cds#13715.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package and Analyze
    • Docker ✔
    • Docs ✔
    • Sonar ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘
    • Standalone tests 1 -
    • Standalone tests 2 -
    • Standalone tests 3 -

@sguiheux sguiheux requested a review from fsamin June 29, 2020 14:14
@sguiheux sguiheux merged commit bf1afd3 into master Jun 29, 2020
@richardlt richardlt deleted the editEnvAsCodeUI branch July 13, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@yesnault yesnault yesnault approved these changes

@fsamin fsamin Awaiting requested review from fsamin fsamin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sguiheux @ovh-cds @yesnault @fsamin @richardlt