Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(engine): keep the main trace.span in context #5287

Merged
merged 3 commits into from
Jul 2, 2020
Merged

fix(engine): keep the main trace.span in context #5287

merged 3 commits into from
Jul 2, 2020

Conversation

fsamin
Copy link
Member

@fsamin fsamin commented Jun 30, 2020

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@fsamin
fix
813138a 
Signed-off-by: francois  samin <[email protected]>
richardlt
richardlt requested changes Jul 1, 2020
View reviewed changes
engine/api/project/dao.go Show resolved Hide resolved
@fsamin
fix
45df03f 
Signed-off-by: francois  samin <[email protected]>
@ovh ovh deleted a comment from ovh-cds Jul 1, 2020
@ovh ovh deleted a comment from ovh-cds Jul 1, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

@fsamin fsamin requested a review from richardlt July 2, 2020 13:38
@richardlt richardlt merged commit 5871741 into master Jul 2, 2020
@ovh ovh deleted a comment from ovh-cds Jul 2, 2020
@ovh ovh deleted a comment from ovh-cds Jul 2, 2020
@ovh ovh deleted a comment from ovh-cds Jul 2, 2020
@ovh ovh deleted a comment from ovh-cds Jul 2, 2020
@richardlt richardlt deleted the fix/engine/span_context branch July 13, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@sguiheux sguiheux sguiheux approved these changes

@yesnault yesnault yesnault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fsamin @yesnault @sguiheux @richardlt