Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): do not loose logs when api restart #5298

Merged
merged 8 commits into from
Jul 6, 2020
Merged

fix(api): do not loose logs when api restart #5298

merged 8 commits into from
Jul 6, 2020

Conversation

sguiheux
Copy link
Collaborator

@sguiheux sguiheux commented Jul 3, 2020

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@sguiheux sguiheux marked this pull request as draft July 3, 2020 14:56
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jul 3, 2020

CDS Report build-all-cds#13781.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

richardlt
richardlt reviewed Jul 3, 2020
View reviewed changes
engine/api/cache/redis.go Outdated Show resolved Hide resolved
engine/cdn/cdn_log.go Show resolved Hide resolved
fsamin
fsamin requested changes Jul 6, 2020
View reviewed changes
engine/cdn/cdn_log.go Show resolved Hide resolved
@sguiheux sguiheux requested a review from fsamin July 6, 2020 07:42
@sguiheux sguiheux changed the title fix: do not loose logs when api restart fix(api): do not loose logs when api restart Jul 6, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

@sguiheux sguiheux marked this pull request as ready for review July 6, 2020 09:01
@sguiheux sguiheux merged commit 10e3e4b into master Jul 6, 2020
@sguiheux sguiheux deleted the fixLogLost branch July 13, 2020 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@fsamin fsamin fsamin approved these changes

@yesnault yesnault yesnault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sguiheux @ovh-cds @yesnault @fsamin @richardlt