Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): craft workflow runs #5355

Merged
merged 6 commits into from
Aug 20, 2020
Merged

fix(api): craft workflow runs #5355

merged 6 commits into from
Aug 20, 2020

Conversation

fsamin
Copy link
Member

@fsamin fsamin commented Jul 30, 2020

No description provided.

@ovh ovh deleted a comment from ovh-cds Jul 31, 2020
@ovh ovh deleted a comment from ovh-cds Jul 31, 2020
sguiheux
sguiheux previously requested changes Jul 31, 2020
View reviewed changes
engine/api/workflow_run_craft.go Show resolved Hide resolved
@ovh ovh deleted a comment from ovh-cds Jul 31, 2020
@fsamin fsamin force-pushed the fix/api/craft_workflow_run branch from b4440e5 to e50bf74 Compare July 31, 2020 13:00
yesnault
yesnault requested changes Aug 4, 2020
View reviewed changes
engine/sql/api/213_workflow_run_crafting.sql Outdated Show resolved Hide resolved
sdk/error.go Outdated Show resolved Hide resolved
@fsamin fsamin requested a review from sguiheux August 19, 2020 07:56
@fsamin fsamin force-pushed the fix/api/craft_workflow_run branch from e50bf74 to 4001154 Compare August 19, 2020 07:59
@fsamin fsamin requested a review from yesnault August 19, 2020 08:00
@ovh-cds
Copy link
Collaborator

ovh-cds commented Aug 19, 2020

CDS Report build-all-cds#14159.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Docs -
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

richardlt
richardlt reviewed Aug 19, 2020
View reviewed changes
sdk/workflow_run.go Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

@ovh ovh deleted a comment from ovh-cds Aug 19, 2020
@fsamin fsamin merged commit a111301 into master Aug 20, 2020
@yesnault yesnault deleted the fix/api/craft_workflow_run branch August 25, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@yesnault yesnault yesnault approved these changes

@sguiheux sguiheux Awaiting requested review from sguiheux sguiheux is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fsamin @ovh-cds @yesnault @sguiheux @richardlt