fix(cdsctl): verbose and insecure config from env or flags #5384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phsym
requested review from
fsamin,
richardlt,
sguiheux and
yesnault
as code owners
…. Especially during a login command Signed-off-by: pierresy <[email protected]>
richardlt
approved these changes
Aug 19, 2020
yesnault
approved these changes
Aug 19, 2020
richardlt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing cdsctl
--verboseand--insecureflags not working all the time, especially during a login commandDescription
cdsctl --verbose --insecure login --api-url https://.....fails when api endpoint uses TLS with an untrusted certificate. Insecure flag is not working as expected. While fixing the use of--insecureflag for the login command, I also fixed it in other places, and fixed the--verboseflag which was not properly handled neither.About tests
cdsctl commands now works on an api endpoint using a self signed certificate
Mentions
@ovh/cds
Signed-off-by: Pierre-Henri Symoneaux [email protected]