-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): basic support for openid-connect authentication provider #5393
Conversation
This enables basic integration with openid-connect authentication providers like Keycloak or Hydra Signed-off-by: phsym <[email protected]>
Handle OIDC driver initialization error Signed-off-by: phsym <[email protected]>
Hi, thanks for the PR can you provide some tips about how you test it ? |
Hi, sure ! I just updated the PR description with the tips |
@yesnault Done by merging your branch into mine, but it messed up the DCO check for some reason
|
Signed-off-by: Yvonnick Esnault <[email protected]> Signed-off-by: phsym <[email protected]>
Signed-off-by: phsym <[email protected]>
Oops sorry, I missclicked on close |
Signed-off-by: phsym <[email protected]>
I just added a check on the "email_verified" OIDC claim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much to your great contribution. Here are some change requests.
Signed-off-by: phsym <[email protected]>
@fsamin Corrections provided based on your comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added 2 suggestions following https://github.com/golang/go/wiki/CodeReviewComments#error-strings
Signed-off-by: phsym <[email protected]>
@fsamin Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This enables basic integration with openid-connect authentication providers like Keycloak or Hydra
About tests
Not sure yet how to automate the tests here, but for manual testing :
docker run -p 4040:8080 -e KEYCLOAK_USER=admin -e KEYCLOAK_PASSWORD=admin quay.io/keycloak/keycloak:11.0.1
@ovh/cds
Signed-off-by: phsym [email protected]