Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: status for all instances #5437

Merged
merged 9 commits into from
Sep 25, 2020
Merged

feat: status for all instances #5437

merged 9 commits into from
Sep 25, 2020

Conversation

yesnault
Copy link
Member

Signed-off-by: Yvonnick Esnault [email protected]

@yesnault
feat: status for all instances
3089f53 
Signed-off-by: Yvonnick Esnault <[email protected]>
@yesnault
fix: cr
eb79bfb 
Signed-off-by: Yvonnick Esnault <[email protected]>
@yesnault yesnault requested a review from richardlt September 24, 2020 21:22
fsamin
fsamin requested changes Sep 25, 2020
View reviewed changes
cli/cdsctl/admin_cdn.go Outdated Show resolved Hide resolved
engine/api/services/dao.go Outdated Show resolved Hide resolved
@yesnault
fix: cr
1b65c77 
Signed-off-by: Yvonnick Esnault <[email protected]>
@yesnault
fix: cr
e1ebf4e 
Signed-off-by: Yvonnick Esnault <[email protected]>
@yesnault yesnault requested a review from fsamin September 25, 2020 08:48
fsamin
fsamin requested changes Sep 25, 2020
View reviewed changes
engine/api/services/dao.go Outdated Show resolved Hide resolved
@yesnault
fix: cr
c7742e2 
Signed-off-by: Yvonnick Esnault <[email protected]>
@yesnault yesnault requested a review from fsamin September 25, 2020 08:54
richardlt
richardlt reviewed Sep 25, 2020
View reviewed changes
engine/api/services/dao.go Outdated Show resolved Hide resolved
engine/api/services/loader.go Outdated Show resolved Hide resolved
@yesnault
fix(repositories/elasticsearch): no auth on status
ef43a71 
as on other services

Signed-off-by: Yvonnick Esnault <[email protected]>
@yesnault
fix: cr
b2853e4 
Signed-off-by: Yvonnick Esnault <[email protected]>
@yesnault yesnault requested a review from richardlt September 25, 2020 11:29
@yesnault
fix: cr
0380f13 
Signed-off-by: Yvonnick Esnault <[email protected]>
@ovh ovh deleted a comment from ovh-cds Sep 25, 2020
@ovh ovh deleted a comment from ovh-cds Sep 25, 2020
@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 25, 2020

CDS Report build-all-cds#14468.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Docs -
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package and Analyze
    • Docker ✔
    • Sonar ✔
  • Integration
    • Docker Compose Tests ✘
    • Standalone Tests ✘
    • Standalone tests 1 -
    • Standalone tests 2 -
    • Standalone tests 3 -

@yesnault
fix: cr
29aaa86 
Signed-off-by: Yvonnick Esnault <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 25, 2020 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yesnault yesnault merged commit 679eb5e into master Sep 25, 2020
@richardlt richardlt deleted the ye-service-status branch September 29, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@sguiheux sguiheux sguiheux approved these changes

@fsamin fsamin fsamin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yesnault @ovh-cds @fsamin @sguiheux @richardlt