fix(api): support utf8 in mail subject #5464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsamin
requested review from
richardlt,
sguiheux and
yesnault
as code owners
sguiheux
approved these changes
Sep 30, 2020
yesnault
approved these changes
Sep 30, 2020
close #5351 Signed-off-by: francois samin <[email protected]>
fsamin
force-pushed
the
fix/api/mail_utf8
branch
from
e657e70 to
ebf6e83
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
richardlt
approved these changes
Oct 1, 2020
maxatome
reviewed
Oct 1, 2020
| headers["Subject"] = subject | ||
| } else { | ||
| // https://tools.ietf.org/html/rfc2047 | ||
| headers["Subject"] = "=?UTF-8?Q?" + subject + "?=" |
There was a problem hiding this comment.
I don't think it is correct.
See 4.2. The "Q" encoding in https://tools.ietf.org/html/rfc2047, non ascii bytes in subject have to be encoded as =HH.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5351
Signed-off-by: francois samin [email protected]