Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): do not clean requirements when job is disabled #5483

Merged
merged 2 commits into from
Oct 8, 2020
Merged

fix(api): do not clean requirements when job is disabled #5483

merged 2 commits into from
Oct 8, 2020

Conversation

sguiheux
Copy link
Collaborator

@sguiheux sguiheux commented Oct 7, 2020

close #3873

@ovh/cds

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ovh-cds
Copy link
Collaborator

ovh-cds commented Oct 7, 2020

CDS Report build-all-cds#14646.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Docs -
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package and Analyze
    • Docker ✔
    • Sonar ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘
    • Standalone tests 1 -
    • Standalone tests 2 -
    • Standalone tests 3 -

@sguiheux sguiheux merged commit e1a5c36 into master Oct 8, 2020
@richardlt richardlt deleted the jobRequirements branch October 13, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@fsamin fsamin fsamin approved these changes

@yesnault yesnault yesnault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix : Disabling a stage (or job) wipe the requirement list
5 participants
@sguiheux @ovh-cds @yesnault @fsamin @richardlt