Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api,ui): remove node run sidebar + remove data from getRuns #5510

Merged
merged 4 commits into from
Oct 19, 2020
Merged

fix(api,ui): remove node run sidebar + remove data from getRuns #5510

merged 4 commits into from
Oct 19, 2020

Conversation

sguiheux
Copy link
Collaborator

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@ovh-cds
Copy link
Collaborator

ovh-cds commented Oct 15, 2020

CDS Report build-all-cds#14747.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Docs -
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@sguiheux sguiheux marked this pull request as ready for review October 16, 2020 09:04
fsamin
fsamin approved these changes Oct 16, 2020
View reviewed changes
engine/api/workflow_run.go
limit, errAtoi = strconv.Atoi(limitS)
if errAtoi != nil {
return sdk.WithStack(sdk.ErrWrongRequest)
limitS := r.FormValue("limit")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

service.FormInt

engine/api/workflow_run.go
// About pagination: [FR] http://blog.octo.com/designer-une-api-rest/#pagination
var limit, offset int

offsetS := r.FormValue("offset")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

service.FormInt

@ovh-cds
Copy link
Collaborator

ovh-cds commented Oct 19, 2020

CDS Report build-all-cds#14759.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Docs -
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 3 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sguiheux sguiheux merged commit 4b4b725 into master Oct 19, 2020
@sguiheux sguiheux deleted the removeNodeRunSidebar branch December 30, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@fsamin fsamin fsamin approved these changes

@yesnault yesnault yesnault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sguiheux @ovh-cds @yesnault @fsamin @richardlt