feat(hatchery/kubernetes): various improvement #5679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsamin
requested review from
richardlt,
sguiheux and
yesnault
as code owners
yesnault
approved these changes
Feb 10, 2021
* new interface to have a cleaner interface to k8s API * don't get the namespace at startup (to reduce the expected roles in k8s RBAC) * don't try to create the namespace (to reduce the expected roles in k8s RBAC) Signed-off-by: francois samin <[email protected]>
fsamin
force-pushed
the
feat/hatchery/k8s_cleanup
branch
from
08021a9 to
01ebf07
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
richardlt
approved these changes
Feb 10, 2021
sguiheux
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: francois samin [email protected]