-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cdn): remove storage unit #5729
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think than rather then checking for unit to delete with a ticker and because dropping a unit is not a usual action. It could be better to have a some commands:
- one to "disable" the unit (off sync, stop loading data from this unit).
- a another to mark all unit_items to delete.
- a last one to direct delete the item that fails if there are still unit_items.
CDS Report build-all-cds#15665.0 ✘
|
CDS Report build-all-cds#15669.0 ✘
|
CDS Report build-all-cds#15674.0 ✘
|
CDS Report build-all-cds#15674.1 ✘
|
SonarCloud Quality Gate failed. |
@ovh/cds